Speed up submit for [novalidate] and [data-remote!=true] forms #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh, nice catch. I'll pull this in tomorrow. |
Contributor
Author
|
@JangoSteve cool. Let me know when we can expect to see this pulled into the gem. Thanks! |
Contributor
|
@JangoSteve tests are green on my machine, do you think we can get this one merged? |
lucasmazza
added a commit
that referenced
this pull request
Mar 12, 2014
Speed up submit for [novalidate] and [data-remote!=true] forms
Member
|
Sorry about that. Yeah, this was good to pull in. Thanks @lucasmazza! |
Member
|
BTW, I don't know what the hell happened 5 months ago where I somehow just completely forgot to pull it in the next day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forms submitted with the
novalidateattribute or without thedata-remoteattribute pay the penalty of unnecessary DOM scans to find blank input elements or file elements, respectively, which are never used. This change moves those DOM scans to a point in the logic where their result could actually be used.