Add support for HTML attributes of optgroups to select helper #43019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
cgunther
force-pushed
the
av-select-optgroup-html-attrs
branch
from
87540cf to
a2d15a1
Compare
Contributor
Author
|
Rebased to resolve staleness. This is still an issue. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
PR rails#11517 updated `grouped_options_for_select` to allow passing HTML attributes of the optgroup as the last element of each array, which is called internally by `select` when it detects grouped choices. However, the `select` helper detected grouped choices by seeing if the [last element is an Array](https://github.com/rails/rails/blob/6ec669b65d5cd47c984661920d670faccbf0920a/actionview/lib/action_view/helpers/tags/select.rb#L37), meaning if you passed a hash of HTML attributes, it would no longer treat the choices as grouped. This conflicted with `grouped_options_for_select`, which assumes the individual options are the [second element](https://github.com/rails/rails/blob/6ec669b65d5cd47c984661920d670faccbf0920a/actionview/lib/action_view/helpers/form_options_helper.rb#L546), not the last element. Now there's agreement between `select` and `grouped_options_for_select` in expecting the individual option choices to be the second element, allowing the hash of HTML attributes to exist as the last element and properly trigger grouped options.
Contributor
Author
|
Rebased to resolve staleness. This is still an issue. |
cgunther
force-pushed
the
av-select-optgroup-html-attrs
branch
from
a2d15a1 to
0387cc1
Compare
|
Is this still an issue? I can review and test the change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #11517 updated
grouped_options_for_selectto allow passing HTML attributes of the optgroup as the last element of each array, which is called internally byselectwhen it detects grouped choices.However, the
selecthelper detected grouped choices by seeing if the last element is an Array, meaning if you passed a hash of HTML attributes, it would no longer treat the choices as grouped. This conflicted withgrouped_options_for_select, which assumes the individual options are the second element, not the last element.Now there's agreement between
selectandgrouped_options_for_selectin expecting the individual option choices to be the second element, allowing the hash of HTML attributes to exist as the last element and properly trigger grouped options.Since this mismatch existed since v4.1 (when #11517 was merged), if this can be backported to at least v6.1, that'd be much appreciated to avoid having to wait for v7.0 to be released to take advantage of.
Thanks!