rescue_from not testable in 3.2 integration tests

[jrochkind]

I have a Rails app with a perfectly standard 'rescue_from' that catches certain exceptions (like ActiveRecord::RecordNotFound) and returns a 404 response.

This does not seem to be testable in a 3.2.2 integration test.

I write a rails integration test::unit with a assert_response(:missing) -- but the exception does not seem to be rescued with the rescue_from, the rescue_from is not being applied. The exception propogates all the way to the top and results in an Error reported, instead of Success.

See also this problem reported by someone else for functional level tests at: http://stackoverflow.com/questions/9286065/rescue-from-in-functional-integration-tests-in-rails-3-2

[rafaelfranca]

Can you provide a failing test case or a sample application that reproduces this issue? Thanks

[drogus]

@jrochkind this is because inegration tests do not test middleware stack and errors are now catched by a middleware. If you need this kind of tests I would just go with simple tests with rack-test that.

[rafaelfranca]

Hey @drogus! Can you point to us where I can find information about this in the code base?

[drogus]

@rafaelfranca so, actually I mixed a few things here. Integration tests (as ActionDispatch::IntegrationTest) should go through the entire stack. Functional tests will not do that, look at ActionController::TestCase#process: https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/test_case.rb#L447

@jrochkind can you specify which test kind are you referring to? There is "functional" in the topic on SO and subject here says about integration, which are two different concepts.

[jrochkind]

Yep, I am doing it in an integration test, although the stackoverflow
was about functional, my error report is integration.

If it is indeed supposed to work there, I will try to produce a
simple test case.

On Thu, Mar 29, 2012 at 3:11 PM, Piotr Sarnacki
reply@reply.github.com
wrote:

@rafaelfranca so, actually I mixed a few things here. Integration tests (as ActionDispatch::IntegrationTest) should go through the entire stack. Functional tests will not do that, look at ActionController::TestCase#process: https://github.com/rails/rails/blob/master/actionpack/lib/action_controller/test_case.rb#L447

@jrochkind can you specify which test kind are you referring to? There is "functional" in the topic on SO and subject here says about integration, which are two different concepts.

---

Reply to this email directly or view it on GitHub:
#5657 (comment)

[jrochkind]

While it's not working in my code, the very simple reproduction case I tried to create does not demonstrate the problem. Moving on trying to figure out what in my code is causing the problem.

One thing is that my code is actually an engine/gem, created with rails plugin new, and runs tests in the "dummy" application created by that generator. It's possible the problem is unique to that, moving on to trying to reproduce simple test case there.

[drogus]

@jrochkind any luck with reproducing this bug?

[ncr]

Here's a sample app reproducing this bug: https://github.com/ncr/exbug

[drogus]

I'm not sure why haven't I thought about that before, but it's not fault of IntegrationTest. In one of the previous versions of rails new config key was introduced in environments/test.rb:

# Raise exceptions instead of rendering exception templates
config.action_dispatch.show_exceptions = false

By default it's set to false and in such situation middlewares will not rescue exceptions and will not show test page. If you would like to not get exceptions in tests, you need to set it to true.

[drogus]

I'm closing this issue as this is not a bug, just misconfiguration, if you still have problems, please reopern or comment.

[ncr]

Solves the problem. Thank you!

[jrochkind]

Perhaps this should be mentioned in docs somewhere, around testing, with example code?

I'm still not clear on the rationale for setting this config as such in testing env. If it makes sense to do so generally, perhaps what's needed is documentation showing an example of how to reset this config on a per-test basis, so you can test your rescue_from's when you want to, but leave it as suggested otherwise.

I feel like there are an increasing number of 'gotchas' in testing rails, where things don't work like you expect in a testing environment, this being one of them. Improved documentation might help, at a minimum. I'm probably not the only one that's going to run into this, and not know how to test rescue_froms and file duplicate tickets on it, and wait 3 months for someone to figure it out, heh.

[drogus]

@jrochkind regarding documentation - access to lifo/docrails is open, feel free to commit clarifications there.

Regarding setting it per test basis - I checked this case while I was writing my answer and it won't work at the moment. Usually I test with this show exceptions set to false, to see failures immediately in my tests (instead of going to logs if there are failures), but I can see that it may be nice to test some specific behavior in rescue_from. I have it on my todo list, but if you have time, feel free to open pull request with such change.