Skip to content

Conversation

@amerine
Copy link
Contributor

@amerine amerine commented Feb 21, 2011

I think a fairly large portion of the people hacking on rails might be using rvm. It might be time to add the .rvmrc to .gitignore so that peoples personal ruby version/gemset don't accidentally get pushed up to rails/rails.

@josevalim
Copy link
Contributor

Is there a time you actually want to share your .rvmrc? .rvmrc is in my ~/.gitignore

@amerine
Copy link
Contributor Author

amerine commented Feb 21, 2011

Sure. Almost every project I work on with teams has an .rvmrc checked in that keeps everyone on the same ruby with a gemset named after the project. The exceptions would be gems, libraries, etc.

@josevalim
Copy link
Contributor

Yeah, I don't share even those. But as YMMV, I have applied your commit, thanks!

@tomstuart
Copy link
Contributor

This has been merged now so the discussion is moot, but as a point of principle (see comments on cd12c36) you should have .rvmrc in your global .gitignore and then explicitly git add -f it in any projects where you want to share it, rather than madly adding it to the individual .gitignores of every project where you don't want to share it.

Whether omitting .rvmrc from Rails' .gitignore would communicate this point to anyone on the planet is, I suppose, a pretty academic consideration.

@amerine
Copy link
Contributor Author

amerine commented Feb 21, 2011

No disagreements from me. Thats just not my workflow. I almost always commit a .rvmrc to the apps I'm working on, and always(almost) ignore them in the libraries.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants