Skip to content

Fix can't modify frozen String error in display_image #30417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kamipo merged 1 commit into from
Aug 26, 2017
Merged

Fix can't modify frozen String error in display_image #30417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actionpack/lib/action_dispatch/system_testing/test_helpers/screenshot_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def output_type
end

def display_image
message = "[Screenshot]: #{image_path}\n"
message = "[Screenshot]: #{image_path}\n".dup

case output_type
when "artifact"
Expand Down
15 changes: 15 additions & 0 deletions actionpack/test/dispatch/system_testing/screenshot_helper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,21 @@ class ScreenshotHelperTest < ActiveSupport::TestCase
end
end
end

test "display_image return artifact format when specify RAILS_SYSTEM_TESTING_SCREENSHOT environment" do
begin
original_output_type = ENV["RAILS_SYSTEM_TESTING_SCREENSHOT"]
ENV["RAILS_SYSTEM_TESTING_SCREENSHOT"] = "artifact"

new_test = DrivenBySeleniumWithChrome.new("x")

new_test.stub :passed?, false do
assert_match "\e]1338;url=artifact://tmp/screenshots/failures_x.png\a", new_test.send(:display_image)
end
ensure
ENV["RAILS_SYSTEM_TESTING_SCREENSHOT"] = original_output_type
end
end
end

class RackTestScreenshotsTest < DrivenByRackTest
Expand Down