Skip to content

Remove 'size' attribute from number_field form helper fixes #3454 #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 1 commit into from
Nov 4, 2011
Merged

Remove 'size' attribute from number_field form helper fixes #3454 #3514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions actionpack/lib/action_view/helpers/form_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,8 @@ def to_input_field_tag(field_type, options = {})

def to_number_field_tag(field_type, options = {})
options = options.stringify_keys
options['size'] ||= nil

if range = options.delete("in") || options.delete("within")
options.update("min" => range.min, "max" => range.max)
end
Expand Down
4 changes: 2 additions & 2 deletions actionpack/test/template/form_helper_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,12 +438,12 @@ def test_email_field
end

def test_number_field
expected = %{<input name="order[quantity]" size="30" max="9" id="order_quantity" type="number" min="1" />}
expected = %{<input name="order[quantity]" max="9" id="order_quantity" type="number" min="1" />}
assert_dom_equal(expected, number_field("order", "quantity", :in => 1...10))
end

def test_range_input
expected = %{<input name="hifi[volume]" step="0.1" size="30" max="11" id="hifi_volume" type="range" min="0" />}
expected = %{<input name="hifi[volume]" step="0.1" max="11" id="hifi_volume" type="range" min="0" />}
assert_dom_equal(expected, range_field("hifi", "volume", :in => 0..11, :step => 0.1))
end

Expand Down