hidde backtrace when parallel tests get interrupted #55720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aronwolf90
force-pushed
the
remove-annoying-backtrace-on-parallel-test-abortion
branch
2 times, most recently
from
d6e239a to
5af11e6
Compare
Contributor
Author
|
@joshuay03 I sow that you worked on something similary. Maybe you can review the PR? NOTE:I totaly understand if you have no time for it. At the end removing the backtrace is just a cosmetic thing :) and there are probably a lot more important things to fix than this. |
Contributor
Yes, I can have a look soonish. Please note though that maintainers prefer not to be tagged directly, and you should follow the process documented in the contributing guides: |
rafaelfranca
force-pushed
the
remove-annoying-backtrace-on-parallel-test-abortion
branch
from
5af11e6 to
9ed47d7
Compare
Right now if one presses CONTROL+C during the parallel test run, one get a very long backtrace that is very annoying. The same problem was solved 11 years ago for the non parallel tests here: * minitest/minitest@b6ec36d * minitest/minitest#503 The reason why the 11 years old fix does not work for the parallel test is, that the rescue happens before the shutdown method gets executed. The shutdown method is where things gets executed. In my opinion, this is wrong, but my guess is, that it was done so, because doing it otherwise would probably require changes in the Minitest gem itself. NOTE: this is my first PR on the rails gem, so I apologize if I made something wrong. Also, there is a big probability that there is a better solution or that I miss some edge case that I am missing because of lack of knowledge.
rafaelfranca
force-pushed
the
remove-annoying-backtrace-on-parallel-test-abortion
branch
from
9ed47d7 to
96c6112
Compare
Contributor
|
Thank you!! @rafaelfranca |
Contributor
Author
|
Thanks! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Right now, if one presses CONTROL+C during the parallel test run, one gets a very long backtrace that is very annoying.
Additional information
The same problem was solved 11 years ago for the non parallel tests here:
The reason why the 11 years old fix does not work for the parallel test is, that the rescue happens before the shutdown method gets executed. The shutdown method is where things get executed. In my opinion, this is wrong, but my guess is, that it was done so, because doing it otherwise would probably require changes in the Minitest gem itself.
NOTE: this is my first PR on the rails gem, so I apologize if I made something wrong. Also, there is a big probability that there is a better solution or that I miss some edge case that I am missing because of lack of knowledge.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]