Skip to content

Conversation

@etagwerker
Copy link
Contributor

@etagwerker etagwerker commented Sep 22, 2025

Hi there,

This PR fixes #55730

It adds two attributes to fix these a11y errors:

  • <img> tag was missing alt attribute/value that described image
  • <html> tag was missing lang attribute/value

Motivation / Background

This Pull Request has been created because screen readers might have trouble because of the missing attributes.

Additional information

More info here:

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one change. Unrelated changes should be opened in separate PRs.
  • Commit message has a detailed description of what changed and why. If this PR fixes a related issue include it in the commit message. Ex: [Fix #issue-number]
  • Tests are added or updated if you fix a bug or add a feature.
  • CHANGELOG files are updated for the changed libraries if there is a behavior change or additional feature. Minor bug fixes and documentation changes should not be included.

- <img> tag was missing alt attribute/value that described image
- <html> tag was missing lang attribute/value
@rails-bot rails-bot bot added the railties label Sep 22, 2025
@rafaelfranca rafaelfranca merged commit 30485c4 into rails:main Sep 22, 2025
3 checks passed
@etagwerker etagwerker deleted the fixes/a11y-errors-on-welcome-template branch September 23, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

railties/lib/rails/templates/rails/welcome/index.html.erb has two small a11y errors

2 participants