Yield key to ActionController::Parameters#fetch
#56400
Merged
+27
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the `ActionController::Parameters#fetch` method did not yield the key to the block when fetching an unknown key. While the `ActionController::Parameters` interface is Hash-like, it **does not** inherit from `Hash` directly. The `Hash#fetch` method yields the key to the block, so this commit changes the `ActionController::Parameters#fetch` behavior to do the same. [Hash#fetch]: https://docs.ruby-lang.org/en/master/Hash.html#method-i-fetch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Prior to this commit, the
ActionController::Parameters#fetchmethod did not yield the key to the block when fetching an unknown key. While theActionController::Parametersinterface is Hash-like, it does not inherit fromHashdirectly.Detail
The Hash#fetch method yields the key to the block, so this commit changes the
ActionController::Parameters#fetchbehavior to do the same.Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]