Make rescue_from_handled.action_controller store the full backtrace#56426
Merged
skipkayhil merged 1 commit intorails:mainfrom Feb 1, 2026
Merged
Make rescue_from_handled.action_controller store the full backtrace#56426skipkayhil merged 1 commit intorails:mainfrom
rescue_from_handled.action_controller store the full backtrace#56426skipkayhil merged 1 commit intorails:mainfrom
Conversation
zzak
force-pushed
the
re-56060
branch
2 times, most recently
from
c02b0a0 to
a993510
Compare
When `config.action_controller.rescue_from_event_backtrace` is `:array`, the payload for this notification will include the full backtrace. This also affects `action_controller.rescue_from_handled` events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
config.action_controller.rescue_from_event_backtraceis:array, the payload for this notification will include the full backtrace.This also affects
action_controller.rescue_from_handledevents.Fixes: #56060
/cc @skipkayhil This is kind of what I had in mind, then we can decide to deprecate and remove that flag (along with the behavior). There is no direct connection to the flag and the payload -- but the combination of changelog, flag, a release, and a deprecation be loud enough to correct any issues that may arise, then again -- it's a brand new event in 8.1, so that might be overkill. Happy to step this back and just change it, but it'd suck to maybe break peoples o11y who might have already started listening for this event.
I did add a test for the
delete_prefix(Rails.root)part, which is also a nice addition I can pull out from this if we need to think about it more.