Remove deprecated fetch cast type#56484
Merged
guilleiguaran merged 2 commits intorails:mainfrom Dec 30, 2025
Merged
Conversation
This removes backward compatibility code added in 5179851 that was needed for Rails 8.0 schema cache dumps. Now that Rails 8.1 is released, all schema cache dumps include the cast_type attribute, so we no longer need to fall back to fetching it from the connection.
This commit completes the cleanup of Rails 8.0 backward compatibility code: - Kept `lookup_cast_type` public (but marked :nodoc:) for internal use by schema_creation - Replaced `column.fetch_cast_type(connection)` with `column.cast_type` in test files - Removed `test_yaml_load_8_0_dump_without_cast_type_still_get_the_right_one` test which was specifically testing Rails 8.0 schema cache compatibility - Removed unused `schema_dump_8_0_path` method
This was referenced Jan 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found these todos from @rafaelfranca .
Now that Rails 8.1 is released, all schema cache dumps include the cast_type attribute, so we no longer need to fall back to fetching it from the connection.