fix(oauth): send CLI User-Agent on OAuth requests - #1019
Merged
Conversation
The OAuth HTTP client was built without a User-Agent, so token refresh (and device-flow) requests reach backboard anonymous — unlike GraphQL requests, which already send "CLI <version>". This makes OAuth failures (e.g. invalid_grant on refresh) unattributable to a CLI version in server logs. Use the same consts::get_user_agent() the GraphQL client uses. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Sets
User-Agent: CLI <version>on the reqwest client used for all OAuth requests (device flow + token refresh), via the sameconsts::get_user_agent()the GraphQL client already uses. Previouslybuild_http_client()set no User-Agent, and reqwest sends none by default. Needed for debugging purposesTesting
cargo checkpasses,cargo fmt --checkclean.🤖 Generated with Claude Code