chore(database): drop the never-read haConversionConfig from the CLI's config shape - #1161
Merged
Merged
Conversation
…s config shape The CLI's ServiceInstance config struct parsed haConversionConfig (and its role selectors) but nothing ever read it -- by design: conversion bounds are read from the COMPANION template record, the same record the server-side gate reads, because a standalone service's own copy can be partial, stale, or absent entirely (the redis template carries none, and the postgres slot shipped a stale one that offered even-voter cluster sizes). Keeping the field parsed was an invitation for a future call site to trust the service's copy and silently skip the real bounds for exactly the engines that need them. Remove it, with a note on the struct saying why it is absent. The rest of this branch's original content -- the image-lineage-scoped revert sweep and any-member-to-root resolution -- landed via #1159 (v5.47.0).
paulocsanz
force-pushed
the
pcs/ha-revert-scope-and-root-targeting
branch
from
August 31, 2026 22:26
04a9936 to
5cdd898
Compare
paulocsanz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto v5.47.0 and rescoped: this branch's original content — the image-lineage-scoped revert debris sweep and any-member-to-root resolution — landed via #1159. What remains is the one piece #1159 didn't carry:
The CLI's
ServiceInstanceconfig struct parsedhaConversionConfig(and its role selectors) but nothing ever read it — by design: conversion bounds are read from the companion template record, the same record the server-side gate reads, because a standalone service's own copy can be partial, stale, or absent entirely (theredistemplate carries none, and the postgres slot shipped a stale one that offered even-voter cluster sizes). Keeping the field parsed was an invitation for a future call site to trust the service's copy and silently skip the real bounds for exactly the engines that need them.Removed, with a note on the struct saying why it is absent.
cargo test— 1310 pass;cargo clippy/cargo fmtclean.