Support --environment for Up + Fix Exit Status'#150
Merged
Conversation
JakeCooper
changed the title
coffee-cup
reviewed
Jul 27, 2021
| return err | ||
| } | ||
| environmentId, err := h.cfg.GetEnvironment() | ||
| environmentId, err := h.cfg.GetCurrentEnvironment() |
Contributor
There was a problem hiding this comment.
Any reason most of the commands call GetEnvironment() as opposed to GetEnvironment to use the environment from flag if it exists?
Contributor
Author
There was a problem hiding this comment.
I don't follow? if you're asking why GetEnvironment doesn't just use the flags cause then we'd have to alter it to take the Cmd as a param and when I did it it was nasty
Still not thritted with this implementation but at least it's clear
coffee-cup
approved these changes
Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.