fix: warning when start command is missing#490
Merged
iloveitaly merged 2 commits intorailwayapp:mainfrom Mar 12, 2026
Merged
Conversation
previously this would only happen if error-missing-start is enabled, which is not enabled by default.
iloveitaly
force-pushed
the
warning-when-no-start
branch
from
63f36d0 to
249736b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Inform the user when no start command is detected during the build process. Previously, this feedback was only provided if the
--error-missing-startflag was enabled.Description
Added a centralized warning message in
core/validate.gothat triggers whenplan.Deploy.StartCmdis empty.Test
Updated
TestValidateStartCommandincore/validate_test.goto verify both warning and error logging levels and content.