fix(config): honor configured deploy base layers#561
Merged
iloveitaly merged 1 commit intoJun 2, 2026
Conversation
iloveitaly
changed the title
Railpack parses deploy.base from railpack.json but previously did not copy it into the deploy builder. Apply non-empty configured deploy base layers so custom runtime images are reflected in the generated plan, including as the base input for runtime apt package steps. Constraint: Runtime apt packages still need to wrap the selected deploy base in packages:apt:runtime. Rejected: Only set deploy.base directly after build | would bypass runtime apt package layering. Confidence: high Scope-risk: narrow Tested: go test ./core/generate -run TestGenerateContextAppliesConfiguredDeployBase Tested: go test ./core/generate -run TestGenerateContext Tested: go test ./core/generate Tested: git diff --check
iloveitaly
force-pushed
the
apply-configured-deploy-base
branch
from
851e74b to
de6fdb8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #551.
deploy.baseis already parsed fromrailpack.json, but it was not copied into the deploy builder during config application. This applies a non-empty configured deploy base so custom runtime images show up in the generated plan.When runtime apt packages are configured, the generated
packages:apt:runtimestep now uses the configured deploy base as its first input, preserving the existing apt layering behavior.Verification:
go test ./core/generate -run TestGenerateContextAppliesConfiguredDeployBasego test ./core/generate -run TestGenerateContextgo test ./core/generategit diff --check