fix(nix): vendor Cargo dependencies - #80
Merged
Merged
Conversation
jakob1379
marked this pull request as ready for review
July 26, 2026 15:43
The package tests use loopback networking, which is unavailable in the Nix sandbox on Darwin. Keep tests in the regular test workflow instead of running them as part of the package derivation. Build the package under the default sandbox in CI so accidental network access or undeclared dependencies cause the check to fail.
Owner
|
Thanks |
bp0lr
pushed a commit
to bp0lr/claude-code-proxy
that referenced
this pull request
Aug 29, 2026
* fix(nix): vendor Cargo dependencies * make nix build hermetic The package tests use loopback networking, which is unavailable in the Nix sandbox on Darwin. Keep tests in the regular test workflow instead of running them as part of the package derivation. Build the package under the default sandbox in CI so accidental network access or undeclared dependencies cause the check to fail. --------- Co-authored-by: Raine Virta <raine.virta@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rustPlatform.buildRustPackageCargo.lockWhy
The custom build phase invoked Cargo without vendored dependencies. Nix's
sandbox blocks network access during builds, so Cargo failed while resolving
index.crates.io.Using the native Rust builder makes the Cargo phase run offline and keeps
dependency versions tied to the lockfile.
Validation
nix build --print-build-logs./result/bin/claude-code-proxy --versionreturned0.1.25AI usage
OpenAI Codex was used during development to diagnose the failure, implement the
change, and run the validation above.