fix(panes): avoid injecting prompt twice for literal agent commands - #242
Merged
Conversation
Owner
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I encountered an edge case where a prompt was being sent twice.
with
agent: piandpanes: [{ command: pi, focus: true }],workmux add dup-probe -b -P PROMPT.mdsends this to the pane:the agent submits the first copy at startup and queues the second. using
command: <agent>instead of the literal name doesn't reproduce (and is how I'm working around this locally for the moment).I think this is because
resolve_pane_command_with_configends withresolved.command = resolved.render_command(), and thenrender_raw_command()readsself.commandback. for a literal agent name, that string already contains the prompt.this PR keeps the pre-prompt command in a private
base_commandfield, but you may well (likely!) have another better solution 🙏