standardise loop increment to ++i across LibFlow siblings#456
standardise loop increment to ++i across LibFlow siblings#456thedavidmeister wants to merge 1 commit into
Conversation
flowERC721 used ++i; flowERC20 and flowERC1155 used i++. All three loops are unchecked so the codegen is identical, but the sibling functions should look identical. Standardised on ++i. Closes #416. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
flowERC721used++i;flowERC20andflowERC1155usedi++. All three loops are insideuncheckedblocks so the codegen is identical, but the sibling functions should look identical. Standardised on++i.Closes #416.
Test plan
forge buildclean🤖 Generated with Claude Code