Skip to content

standardise loop increment to ++i across LibFlow siblings#456

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-05-07-issue-416-libflow-loop-increment-style
Open

standardise loop increment to ++i across LibFlow siblings#456
thedavidmeister wants to merge 1 commit into
mainfrom
2026-05-07-issue-416-libflow-loop-increment-style

Conversation

@thedavidmeister
Copy link
Copy Markdown
Contributor

Summary

flowERC721 used ++i; flowERC20 and flowERC1155 used i++. All three loops are inside unchecked blocks so the codegen is identical, but the sibling functions should look identical. Standardised on ++i.

Closes #416.

Test plan

  • forge build clean

🤖 Generated with Claude Code

flowERC721 used ++i; flowERC20 and flowERC1155 used i++. All three
loops are unchecked so the codegen is identical, but the sibling
functions should look identical. Standardised on ++i.

Closes #416.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 7, 2026

Warning

Rate limit exceeded

@thedavidmeister has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 56 minutes and 31 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: a2b15196-0f50-4604-857c-ed75738e5747

📥 Commits

Reviewing files that changed from the base of the PR and between ceaea3c and 59e7f65.

📒 Files selected for processing (1)
  • src/lib/LibFlow.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-07-issue-416-libflow-loop-increment-style

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister thedavidmeister self-assigned this May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[A23-10] [INFO] LibFlow sibling loops use inconsistent i++/++i increment

1 participant