Skip to content

standardise loop increment to ++i across LibFlow siblings #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thedavidmeister wants to merge 1 commit into
base: main
Choose a base branch
from
Open

standardise loop increment to ++i across LibFlow siblings #456

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/lib/LibFlow.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ library LibFlow {
function flowERC20(FlowTransferV1 memory flowTransfer) internal {
unchecked {
ERC20Transfer memory transfer;
for (uint256 i = 0; i < flowTransfer.erc20.length; i++) {
for (uint256 i = 0; i < flowTransfer.erc20.length; ++i) {
transfer = flowTransfer.erc20[i];
// We don't support `from` as anyone other than `you` or `me`
// as this would allow for all kinds of issues re: approvals.
Expand Down Expand Up @@ -129,7 +129,7 @@ library LibFlow {
function flowERC1155(FlowTransferV1 memory flowTransfer) internal {
unchecked {
ERC1155Transfer memory transfer;
for (uint256 i = 0; i < flowTransfer.erc1155.length; i++) {
for (uint256 i = 0; i < flowTransfer.erc1155.length; ++i) {
transfer = flowTransfer.erc1155[i];
if (transfer.from != msg.sender && transfer.from != address(this)) {
revert UnsupportedERC1155Flow();
Expand Down
Loading