Skip to content

chore(audit): fix Protofire PDF path + drop resolved legacy audit-run dirs - #14

Merged
thedavidmeister merged 1 commit into
mainfrom
tidy-audit-dir-protofire-path-and-legacy-md
Jul 14, 2026
Merged

chore(audit): fix Protofire PDF path + drop resolved legacy audit-run dirs#14
thedavidmeister merged 1 commit into
mainfrom
tidy-audit-dir-protofire-path-and-legacy-md

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Tidies rain.deploy/audit/: fixes the mispathed Protofire PDF so the rain-org-health scanner picks it up, and removes two stale internal audit-run dirs.

1. Mispathed Protofire PDF → audit/protofire/ with a commit anchor

before after
audit/protofire.rain.deploy.feb-2026.pdf audit/protofire/rain.deploy.1af8ca2a981c2f67844f343e224f4c7b1969de1c.feb-2026.pdf

Pure git mv (bytes unchanged). The scanner scopes Protofire audits to audit/protofire/*.pdf and reads the audited commit from a hex anchor token in the filename; flat in audit/ with no anchor, this PDF was invisible (rain.deploy read as never-audited).

Anchor: no tag existed at audit time (every tag is May/June 2026; the PDF is Feb), so it anchors to the audited commit 1af8ca2a981c ("more logs", 2026-02-08) — confirmed by @thedavidmeister. Drift will size 1af8ca2 → main.

2. Delete the resolved legacy audit-run dirs

audit/2026-03-05-01/ and audit/2026-03-05-02/ are internal audit-skill outputs in the old committed-to-repo format (pass0..pass5 + triage.md). Every finding across both runs is already resolved, so they carry no open work:

  • 2026-03-05-01: 10 FIXED, 1 DISMISSED
  • 2026-03-05-02: 12 FIXED, 1 DOCUMENTED

Each finding has a concrete remediation recorded in its triage.md (added the LibRainDeploy.t.sol test file, TOCTOU→codehash-recheck split, five untested Zoltu-factory revert paths now tested, NatSpec/naming fixes, assembly magic-number comments, etc.). Nothing to convert to issues. This format is superseded by the current audit skill (files findings as GitHub issues + commits .audit/last-run.json).

Deleting removes the historical record, not the fixes (all landed in source).

🤖 Generated with Claude Code

… dirs

The org-health scanner scopes Protofire audits to audit/protofire/*.pdf and reads
the audited commit from an anchor token in the filename. Move the Feb-2026
Protofire PDF out of the flat audit/ dir into audit/protofire/, anchored to the
audited commit 1af8ca2 (confirmed by the maintainer; no tag existed at audit time
— every tag is May/June 2026).

Delete the two 2026-03-05 audit-skill run dirs (pass0..pass5 + triage): every
finding across both runs is FIXED or DISMISSED per its triage.md (run-01: 10
FIXED / 1 DISMISSED; run-02: 12 FIXED / 1 DOCUMENTED), so they carry no open
work. Legacy committed-to-repo audit output, superseded by the current skill's
issue-filing + .audit/last-run.json.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thedavidmeister, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: d2a16a13-c61e-4cd3-898e-c5a34cd99d97

📥 Commits

Reviewing files that changed from the base of the PR and between 80efcb7 and 85cd978.

⛔ Files ignored due to path filters (1)
  • audit/protofire/rain.deploy.1af8ca2a981c2f67844f343e224f4c7b1969de1c.feb-2026.pdf is excluded by !**/*.pdf
📒 Files selected for processing (14)
  • audit/2026-03-05-01/pass0/process.md
  • audit/2026-03-05-01/pass1/LibRainDeploy.md
  • audit/2026-03-05-01/pass2/LibRainDeploy.md
  • audit/2026-03-05-01/pass3/LibRainDeploy.md
  • audit/2026-03-05-01/pass4/LibRainDeploy.md
  • audit/2026-03-05-01/pass5/LibRainDeploy.md
  • audit/2026-03-05-01/triage.md
  • audit/2026-03-05-02/pass0/process.md
  • audit/2026-03-05-02/pass1/LibRainDeploy.md
  • audit/2026-03-05-02/pass2/LibRainDeploy.md
  • audit/2026-03-05-02/pass3/LibRainDeploy.md
  • audit/2026-03-05-02/pass4/LibRainDeploy.md
  • audit/2026-03-05-02/pass5/LibRainDeploy.md
  • audit/2026-03-05-02/triage.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tidy-audit-dir-protofire-path-and-legacy-md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@thedavidmeister

Copy link
Copy Markdown
Contributor Author

Reviewed 85cd978: ready — moves the Feb-2026 Protofire PDF into audit/protofire/ anchored to the audited commit 1af8ca2 (maintainer-confirmed), and deletes the two 2026-03-05 audit-run dirs whose findings are all FIXED/DISMISSED. PDF is a pure git mv (bytes unchanged); no source touched. All CI green (legal/static/test + CodeRabbit); mergeState CLEAN.

@thedavidmeister
thedavidmeister merged commit 4422e29 into main Jul 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant