Update fetch orders query performance by findolor · Pull Request #2304 · rainlanguage/raindex

findolor · 2025-11-06T15:15:28Z

Chained PR

Add local db card component to sidebar for displaying status #2302

Motivation

Previous fetch orders query was doing a lot of I/O and wasm-to-js interactions and because of that the response time was not that good. This PR aims to improve performance by reducing the number of queries that need to be made and only introduce a single query

Solution

Move local db related order logic to its own module
Refactor fetch orders query
Update tests

Checks

By submitting this for review, I'm confirming I've done the following:

made this PR as small as possible
unit-tested any new functionality
linked any relevant issues or PRs
included screenshots (if this involves a front-end change)

Summary by CodeRabbit

New Features
- Query orders across multiple chains and orderbooks in one request.
- Richer order payloads: chain id, timestamps, block info, transaction hash, structured inputs/outputs, trade counts, activity flag and metadata.
- Consolidated local-DB order retrieval and conversion into unified order objects.
Bug Fixes
- Improved normalization (lowercasing) and deduplication of input filters for consistent results.
- More reliable aggregation of trades and vault balances.
Chores
- Updated registry and remote settings URLs.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2025-11-06T15:15:45Z

Walkthrough

Adds multi-chain and multi-orderbook support to local DB order fetching, expands LocalDbOrder fields, rewrites the SQL to use derived tables and JSON aggregation, consolidates RaindexClient local-DB order retrieval and conversion paths, and updates frontend remote registry/settings URLs.

Changes

Cohort / File(s)	Summary
Local DB Query API & Builder `crates/common/src/local_db/query/fetch_orders/mod.rs`	`FetchOrdersArgs` now includes `chain_ids: Vec<u32>` and `orderbook_addresses: Vec<Address>`; `LocalDbOrder` expanded with chain_id, timestamps, orderbook_address, order_bytes, transaction_hash, inputs/outputs, trade_count, active, meta; `build_fetch_orders_stmt` signature changed to accept only `&FetchOrdersArgs`. Query-building deduplicates/sorts and binds multi-list params across multiple clause sections.
SQL Template Rewrite `crates/common/src/local_db/query/fetch_orders/query.sql`	Rewrote query to use derived tables and ROW_NUMBER ranking (la, fa), introduced vo/vb/tc/cc subqueries, switched to json_group_array for structured IO objects, consolidated trade_count, adjusted joins/aliases and expanded GROUP BY to include chain_id and orderbook_address.
RaindexClient: local_db module add `crates/common/src/raindex_client/local_db/mod.rs`	Added `pub mod orders;` to expose local-DB orders handling.
RaindexClient: local DB orders logic `crates/common/src/raindex_client/local_db/orders.rs`	New module: `parse_io_vaults` for JSON -> LocalDbVault parsing; `get_orders_local_db` and `get_order_by_hash_local_db` methods to fetch LocalDbOrder(s), parse inputs/outputs, and convert to `RaindexOrder`. Includes wasm-targeted tests adjusted to new payload shapes.
RaindexClient: fetch_orders call-site `crates/common/src/raindex_client/local_db/query/fetch_orders.rs`	`fetch_orders` no longer requires `OrderbookIdentifier`; now takes `FetchOrdersArgs` only and uses builder `build_fetch_orders_stmt(&args)` to derive SQL. Tests and call sites updated accordingly.
RaindexClient: orders conversion `crates/common/src/raindex_client/orders.rs`	Added `RaindexOrder::from_local_db_order(...)` to map `LocalDbOrder` + parsed vaults into `RaindexOrder`. Consolidated local-DB retrieval flow to use unified fetch path; removed per-id/per-hash granular fetch routines. Added serde/Tsify imports and extended wasm bindings/accessors.
Tests: trades & wasm adjustments `crates/common/src/raindex_client/trades.rs`	Test fixtures switched to JSON payloads and HashMap-based vault lookup (lowercased keys); SQL test callback signature tightened to `FnMut(String, JsValue) -> JsValue` and updated to match json_group_array output and lowercased io_type checks.
Frontend constants `packages/webapp/src/lib/constants.ts`, `tauri-app/src/lib/services/loadRemoteSettings.ts`	`REGISTRY_URL` and `REMOTE_SETTINGS_URL` string literals updated to new commit hashes/URLs.

sequenceDiagram
    autonumber
    participant Client as RaindexClient
    participant Builder as SQL Builder
    participant SQL as LocalDB / SQL Engine
    participant Parser as IO Parser
    participant Conv as Conversion Layer

    Client->>Builder: build_fetch_orders_stmt(&FetchOrdersArgs)
    Builder->>SQL: execute parameterized SQL (multi-chain, multi-orderbook)
    SQL->>SQL: derive latest/first orders (ROW_NUMBER), compute vo/vb/tc/cc, aggregate IO as json_group_array
    SQL-->>Client: return Vec<LocalDbOrder>
    Client->>Parser: parse_io_vaults(inputs), parse_io_vaults(outputs)
    Parser-->>Conv: Vec<LocalDbVault> (inputs/outputs)
    Conv->>Client: RaindexOrder::from_local_db_order(local_order, inputs, outputs)

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~50 minutes

Review focus:
- SQL rewrite: verify ROW_NUMBER usage, join conditions, aggregations, json_group_array shape, and GROUP BY correctness.
- Query builder: ensure multi-list dedup/sort and consistent multi-clause parameter binding.
- Conversion/parsing: validate parse_io_vaults and from_local_db_order mapping and error handling.
- Call-site changes: confirm all fetch_orders call sites/tests updated to the new signature.

Possibly related PRs

Add order related data structures and functions #1947 — related changes to raindex_client orders/local-DB conversion and fetch paths.
Update order details to use local db #2152 — related consolidation of local-DB order retrieval into raindex_client.
Update settings, strats commit #1973 — related update of REGISTRY_URL / REMOTE_SETTINGS_URL constants.

Suggested labels

rust, enhancement

Suggested reviewers

hardyjosh
0xgleb

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Update fetch orders query performance' directly relates to the main objective of refactoring the fetch orders query to improve performance by reducing queries and wasm-to-JS interactions.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch local-db-orders-query

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e219ad6 and 5f129fe.

📒 Files selected for processing (1)

crates/common/src/raindex_client/local_db/mod.rs (1 hunks)

🧰 Additional context used

📓 Path-based instructions (3)

crates/**/*.rs

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

crates/**/*.rs: For Rust crates in crates/*, run lints using nix develop -c cargo clippy --workspace --all-targets --all-features -D warnings
For Rust crates in crates/*, run tests using nix develop -c cargo test --workspace or --package <crate>

Files:

crates/common/src/raindex_client/local_db/mod.rs

**/crates/**

📄 CodeRabbit inference engine (AGENTS.md)

Rust workspace organized as crates/* with subdirectories: cli, common, bindings, js_api, quote, subgraph, settings, math, integration_tests

Files:

crates/common/src/raindex_client/local_db/mod.rs

**/*.rs

📄 CodeRabbit inference engine (AGENTS.md)

**/*.rs: Rust: format code with nix develop -c cargo fmt --all
Rust: lint with nix develop -c rainix-rs-static (preconfigured flags included)
Rust: crates and modules use snake_case; types use PascalCase

Files:

crates/common/src/raindex_client/local_db/mod.rs

🧠 Learnings (19)

📓 Common learnings

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1994
File: crates/common/src/raindex_client/vaults.rs:282-292
Timestamp: 2025-07-15T08:01:38.534Z
Learning: In the rainlanguage/rain.orderbook codebase, findolor prefers to avoid concurrency optimizations like using `futures::future::try_join_all` for parallel processing of balance changes, considering such optimizations "not that critical at the moment" when the performance impact is minimal.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1956
File: crates/common/src/fuzz/mod.rs:64-64
Timestamp: 2025-07-04T09:02:57.301Z
Learning: In rainlanguage/rain.orderbook, user findolor prefers to limit type consistency changes to only the parts directly related to the current work scope. For example, when updating chain_id fields from u64 to u32 in fuzz-related code, unrelated files like tauri-app wallet commands can remain as u64 if they serve different purposes and aren't part of the current changes.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:26:31.566Z
Learning: For PR #1884 and future PRs in rainlanguage/rain.orderbook repository, provide PR size reports in a separate comment with ONLY the exact format "TOTAL=number\nADDITIONS=number\nDELETIONS=number", without any additional text or explanation. Reports should exclude irrelevant files such as lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock).

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2117
File: crates/js_api/src/gui/select_tokens.rs:421-424
Timestamp: 2025-09-02T08:04:34.729Z
Learning: User findolor in the rainlanguage/rain.orderbook codebase prefers not to change test code when tests are already passing, even if there appear to be type mismatches or potential issues. Working tests should be left alone unless there are actual errors.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:25:47.873Z
Learning: After each new commit review for rainlanguage/rain.orderbook repository, generate a PR size report in a separate comment with the format: "TOTAL=number ADDITIONS=number DELETIONS=number". This report should exclude irrelevant files such as lock files (e.g., package-lock.json, cargo.lock).

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1913
File: Cargo.toml:55-55
Timestamp: 2025-06-06T16:38:04.182Z
Learning: In rain.orderbook repository, during PR chains involving dependency updates, wasm-bindgen-utils may temporarily point to git commits that don't contain the full required functionality, with the understanding that subsequent PRs in the chain will update it to the correct commit.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2237
File: crates/common/src/raindex_client/local_db/sync.rs:79-89
Timestamp: 2025-10-18T10:38:41.273Z
Learning: In `crates/common/src/raindex_client/local_db/sync.rs`, the sync_database method currently only supports indexing a single orderbook per chain ID, which is why `.first()` is used to select the orderbook configuration. Multi-orderbook support per chain ID is planned for future PRs.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2202
File: crates/common/src/raindex_client/local_db/sync.rs:33-34
Timestamp: 2025-10-14T07:51:55.148Z
Learning: In `crates/common/src/raindex_client/local_db/sync.rs`, the hard-coded `DEFAULT_SYNC_CHAIN_ID` constant (set to `SUPPORTED_LOCAL_DB_CHAINS[0]`) will be replaced with proper chain ID handling in downstream PRs as part of the multi-network/orderbook implementation.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2145
File: crates/common/src/raindex_client/local_db/query/fetch_orders/query.sql:6-7
Timestamp: 2025-10-06T11:28:30.692Z
Learning: In `crates/common/src/raindex_client/local_db/query/fetch_orders/query.sql`, the orderbook_address is currently hardcoded to '0x2f209e5b67A33B8fE96E28f24628dF6Da301c8eB' because the system only supports a single orderbook at the moment. Multiorderbook logic is not yet implemented and will be added in the future.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2145
File: crates/common/src/raindex_client/local_db/query/create_tables/query.sql:71-72
Timestamp: 2025-10-06T11:44:07.888Z
Learning: The local DB feature in the rain.orderbook codebase is not live yet (as of PR #2145), so schema migrations for existing databases are not required when modifying table structures in `crates/common/src/raindex_client/local_db/query/create_tables/query.sql`.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2155
File: crates/common/src/raindex_client/trades.rs:133-152
Timestamp: 2025-10-06T14:13:18.531Z
Learning: In the rain.orderbook codebase, the `page` parameter in `RaindexOrder::get_trades_list` method (in crates/common/src/raindex_client/trades.rs) is kept for backwards compatibility with subgraph logic, but the LocalDb fast-path intentionally returns all trades without implementing pagination.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2278
File: packages/webapp/src/lib/services/startLocalDbSync.ts:23-29
Timestamp: 2025-10-29T13:29:29.578Z
Learning: In packages/webapp/src/lib/services/startLocalDbSync.ts, the hard-coded default orderbook address '0x2f209e5b67A33B8fE96E28f24628dF6Da301c8eB' is a temporary placeholder that will be removed when new sync logic is introduced in the Raindex client, as documented in the NOTE comment.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2155
File: crates/common/src/raindex_client/local_db/query/fetch_order_trades/query.sql:86-108
Timestamp: 2025-10-06T14:12:05.824Z
Learning: CTEs (Common Table Expressions) are not supported in the local DB SQL implementation used in the rain.orderbook codebase.

Learnt from: brusherru
Repo: rainlanguage/rain.orderbook PR: 2036
File: crates/js_api/src/filters/raindex_filter_store.rs:319-336
Timestamp: 2025-08-01T07:44:53.910Z
Learning: In the rainlanguage/rain.orderbook project's RaindexFilterStore (crates/js_api/src/filters/raindex_filter_store.rs), the team chose a simplified monolithic approach with hard-coded keys and default auto-save behavior over configurable stores. The update_vaults method intentionally auto-saves to both localStorage and URL after each update as the default behavior, following a design evolution from a previous configurable approach.

📚 Learning: 2025-10-06T11:44:07.888Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2145
File: crates/common/src/raindex_client/local_db/query/create_tables/query.sql:71-72
Timestamp: 2025-10-06T11:44:07.888Z
Learning: The local DB feature in the rain.orderbook codebase is not live yet (as of PR #2145), so schema migrations for existing databases are not required when modifying table structures in `crates/common/src/raindex_client/local_db/query/create_tables/query.sql`.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-10-18T10:38:41.273Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2237
File: crates/common/src/raindex_client/local_db/sync.rs:79-89
Timestamp: 2025-10-18T10:38:41.273Z
Learning: In `crates/common/src/raindex_client/local_db/sync.rs`, the sync_database method currently only supports indexing a single orderbook per chain ID, which is why `.first()` is used to select the orderbook configuration. Multi-orderbook support per chain ID is planned for future PRs.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-10-06T14:13:18.531Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2155
File: crates/common/src/raindex_client/trades.rs:133-152
Timestamp: 2025-10-06T14:13:18.531Z
Learning: In the rain.orderbook codebase, the `page` parameter in `RaindexOrder::get_trades_list` method (in crates/common/src/raindex_client/trades.rs) is kept for backwards compatibility with subgraph logic, but the LocalDb fast-path intentionally returns all trades without implementing pagination.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-10-02T19:17:20.332Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2163
File: crates/common/src/raindex_client/orders.rs:738-741
Timestamp: 2025-10-02T19:17:20.332Z
Learning: In crates/common/src/raindex_client/orders.rs, fetch_dotrain_source() is intentionally called in try_from_sg_order for every order conversion because the dotrain source information is needed immediately. A future optimization with local DB logic is planned to eliminate the network round-trip concern.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-10-13T12:57:05.900Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2198
File: crates/common/src/raindex_client/local_db/query/fetch_store_addresses/mod.rs:7-8
Timestamp: 2025-10-13T12:57:05.900Z
Learning: In the rain.orderbook repository, using unqualified serde helper names (e.g., `#[serde(with = "serde_address")]`) that rely on glob imports is acceptable and does not need to be changed to fully qualified paths.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-10-06T11:13:29.956Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2123
File: crates/common/src/raindex_client/local_db/mod.rs:23-29
Timestamp: 2025-10-06T11:13:29.956Z
Learning: In `crates/common/src/raindex_client/local_db/mod.rs`, the `Default` implementation for `LocalDb` that creates an RPC client pointing to `http://localhost:4444` is acceptable because the RPC client must be explicitly configured before actual usage in production scenarios.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-06-24T08:46:03.368Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1947
File: crates/common/src/raindex_client/orders.rs:98-125
Timestamp: 2025-06-24T08:46:03.368Z
Learning: In the vault merging logic in crates/common/src/raindex_client/orders.rs, optimization isn't necessary because the maximum list items are usually around 5 items. For such small datasets, the simple three-loop approach is preferred over HashMap-based optimization due to clarity and minimal performance impact.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-05-17T15:32:28.733Z

Learnt from: 0xgleb
Repo: rainlanguage/rain.orderbook PR: 1790
File: tauri-app/src-tauri/src/commands/vault.rs:67-67
Timestamp: 2025-05-17T15:32:28.733Z
Learning: For the PR focused on testing Tauri commands::order module, the generic type parameter R: Runtime was selectively added where needed for the PR scope, applying the changes primarily to order.rs and related files while leaving other modules like vault.rs for potential future refactoring.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-10-06T11:28:30.692Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2145
File: crates/common/src/raindex_client/local_db/query/fetch_orders/query.sql:6-7
Timestamp: 2025-10-06T11:28:30.692Z
Learning: In `crates/common/src/raindex_client/local_db/query/fetch_orders/query.sql`, the orderbook_address is currently hardcoded to '0x2f209e5b67A33B8fE96E28f24628dF6Da301c8eB' because the system only supports a single orderbook at the moment. Multiorderbook logic is not yet implemented and will be added in the future.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-10-14T07:51:55.148Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2202
File: crates/common/src/raindex_client/local_db/sync.rs:33-34
Timestamp: 2025-10-14T07:51:55.148Z
Learning: In `crates/common/src/raindex_client/local_db/sync.rs`, the hard-coded `DEFAULT_SYNC_CHAIN_ID` constant (set to `SUPPORTED_LOCAL_DB_CHAINS[0]`) will be replaced with proper chain ID handling in downstream PRs as part of the multi-network/orderbook implementation.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-05-14T04:49:14.621Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1710
File: crates/quote/Cargo.toml:30-30
Timestamp: 2025-05-14T04:49:14.621Z
Learning: In the rain.orderbook repository, wasm-bindgen-utils is intentionally used as an unconditional dependency because non-wasm targets (like tests) sometimes need to use it.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-10-21T05:16:07.124Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2256
File: crates/common/src/raindex_client/local_db/query/fetch_tables.rs:46-52
Timestamp: 2025-10-21T05:16:07.124Z
Learning: In Rust projects using wasm_bindgen_utils, the glob import `use wasm_bindgen_utils::prelude::*;` re-exports `Closure` from wasm_bindgen, so `Closure::wrap` can be used without explicitly importing `use wasm_bindgen::prelude::Closure;`.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-06-06T16:38:04.182Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1913
File: Cargo.toml:55-55
Timestamp: 2025-06-06T16:38:04.182Z
Learning: In rain.orderbook repository, during PR chains involving dependency updates, wasm-bindgen-utils may temporarily point to git commits that don't contain the full required functionality, with the understanding that subsequent PRs in the chain will update it to the correct commit.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-04-30T09:28:36.960Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1715
File: crates/js_api/src/common/mod.rs:111-118
Timestamp: 2025-04-30T09:28:36.960Z
Learning: In the rain.orderbook repository, the WASM tests are already properly configured with conditional compilation using `#[cfg(target_family = "wasm")]` and `#[cfg(not(target_family = "wasm"))]`, and don't require additional `wasm_bindgen_test_configure!(run_in_browser)` directives.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-08-01T09:07:20.383Z

Learnt from: brusherru
Repo: rainlanguage/rain.orderbook PR: 2044
File: packages/orderbook/README.md:186-189
Timestamp: 2025-08-01T09:07:20.383Z
Learning: In the rainlanguage/rain.orderbook project, Rust methods on structs like RaindexVaultsList are exported as JavaScript getters in WASM bindings using #[wasm_bindgen(getter)]. This means while the Rust code uses method calls like items(), the JavaScript/WASM API exposes them as property access like .items. The README.md correctly documents the JavaScript API surface, not the Rust implementation details.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-05-19T13:40:56.080Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1858
File: crates/subgraph/src/orderbook_client/mod.rs:54-58
Timestamp: 2025-05-19T13:40:56.080Z
Learning: The `wasm_bindgen_utils` crate in the Rain Orderbook project handles conditional compilation for `JsValue` and `JsError` internally, allowing `impl From<Error> for JsValue` to work on non-WASM targets without explicit cfg guards.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-05-14T05:13:59.713Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1744
File: crates/subgraph/src/orderbook_client.rs:44-46
Timestamp: 2025-05-14T05:13:59.713Z
Learning: In the rain.orderbook project, WASM dependencies are intentionally made available in non-WASM targets to facilitate testing of WASM-related functionality, so conditional compilation guards like `#[cfg(target_family = "wasm")]` should not be added to imports or implementations that may be needed for tests.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

📚 Learning: 2025-06-24T13:30:02.968Z

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1950
File: crates/common/src/raindex_client/transactions.rs:34-38
Timestamp: 2025-06-24T13:30:02.968Z
Learning: When using #[wasm_bindgen] on an impl block, all methods within that block must have wasm_bindgen attributes, even if they are conditionally compiled for non-WASM targets using #[cfg(not(target_family = "wasm"))]. Removing these attributes causes compiler errors because the wasm_bindgen macro expansion processes the entire impl block and expects consistent attribute usage across all methods.

Applied to files:

crates/common/src/raindex_client/local_db/mod.rs

🧬 Code graph analysis (1)

crates/common/src/raindex_client/local_db/mod.rs (3)

crates/common/src/raindex_client/remove_orders.rs (1)

orders (69-79)

crates/common/src/raindex_client/orders.rs (1)

orders (633-651)

crates/common/src/raindex_client/add_orders.rs (1)

orders (67-77)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build-tauri (ubuntu-22.04, true)

🔇 Additional comments (1)

crates/common/src/raindex_client/local_db/mod.rs (1)

10-10: LGTM! New orders submodule follows conventions.

The addition of the orders module is consistent with the PR objective to consolidate local DB order logic into a dedicated module. The module file exists at crates/common/src/raindex_client/local_db/orders.rs and the declaration follows Rust conventions with appropriate public visibility.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

findolor · 2025-11-17T15:14:47Z

@coderabbitai review

coderabbitai · 2025-11-17T15:15:05Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

0xgleb · 2025-11-17T19:30:29Z

+    chain_ids.sort_unstable();
+    chain_ids.dedup();
+
+    // Orderbook addresses (lowercase, deduplicated)


It's a list of addresses so inaccurate comment

As in they can't be lowercase or uppercase

0xgleb · 2025-11-17T19:31:48Z

+        let args = FetchOrdersArgs {
+            chain_ids: vec![1],
+            orderbook_addresses: vec![
+                Address::from_str("0xAbCDeF0000000000000000000000000000000000").unwrap(),


Why not the address! macro?

github-actions · 2025-12-01T16:25:08Z

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

Simple bug fixes, typos, or minor refactoring
Single-purpose changes affecting 1-2 files
Documentation updates
Configuration tweaks
Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

Fix typo in variable name
Update README with new instructions
Adjust configuration values
Simple one-line bug fixes
Import statement cleanup

Medium (M)

Characteristics:

Feature additions or enhancements
Refactoring that touches multiple files but maintains existing behavior
Breaking changes with backward compatibility
Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

Add new feature or component
Refactor common utility functions
Update dependencies with minor breaking changes
Add new component with tests
Performance optimizations
More complex bug fixes

Large (L)

Characteristics:

Major feature implementations
Breaking changes or API redesigns
Complex refactoring across multiple modules
New architectural patterns or significant design changes
Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

Complete new feature with frontend/backend changes
Protocol upgrades or breaking changes
Major architectural refactoring
Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

Test coverage impact: More comprehensive test changes lean toward larger classification
Risk level: Changes to critical systems bump up a size category
Team familiarity: Novel patterns or technologies increase complexity

Notes:

the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
do not include any additional text, only the size classification
your assessment comment must not include tips or additional sections
do NOT tag me or anyone else on your comment

coderabbitai · 2025-12-01T16:25:57Z

Tip

For best results, initiate chat on the files or code changes.

SIZE=L

🧠 Learnings used

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:42.275Z
Learning: For PR #1884, after each commit review, I should provide a new comment with a PR size report in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding irrelevant files such as lock files (package-lock.json, cargo.lock, etc.).

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:42.275Z
Learning: After each commit in PR #1884, I should provide a new comment with the PR size report in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`. The report should exclude irrelevant files such as lock files (e.g., package-lock.json, cargo.lock).

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:25:47.873Z
Learning: After each new commit review for rainlanguage/rain.orderbook repository, generate a PR size report in a separate comment with the format: "TOTAL=number ADDITIONS=number DELETIONS=number". This report should exclude irrelevant files such as lock files (e.g., package-lock.json, cargo.lock).

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:25:47.873Z
Learning: After each new commit review for rainlanguage/rain.orderbook repository, generate a PR size report in a separate comment with the exact format: "TOTAL=number\nADDITIONS=number\nDELETIONS=number". This report should exclude irrelevant files such as lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock).

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T22:14:22.646Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, I must consistently report the PR size after EVERY new commit in the exact format "TOTAL=number\nADDITIONS=number\nDELETIONS=number" without any formatting blocks. The report must exclude lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock) and can be included either as part of the review or as a separate comment.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T22:14:22.646Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, I must consistently report the PR size after EVERY new commit in the exact format "TOTAL=number\nADDITIONS=number\nDELETIONS=number" without any additional text or formatting blocks. The report must exclude lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock) and can be included either as part of the review or as a separate comment.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T22:46:08.530Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, the PR size report should be the only content in the comment - no text before it, no text after it, no formatting blocks, just the raw report in the exact format: "TOTAL=number\nADDITIONS=number\nDELETIONS=number". The report must exclude lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock).

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1971
File: .github/workflows/vercel-docs-prod.yaml:32-34
Timestamp: 2025-07-11T12:30:09.245Z
Learning: findolor prefers not to pin Node versions explicitly in GitHub Actions workflows when using Nix with webapp-shell, considering the current setup sufficient for deterministic builds in the rainlanguage/rain.orderbook project.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1971
File: .github/workflows/vercel-docs-prod.yaml:10-14
Timestamp: 2025-07-11T12:29:49.284Z
Learning: In GitHub Actions workflows for the rainlanguage/rain.orderbook project, findolor is comfortable with job names that may seem misleading (like "Deploy-Docs-Preview" in a production workflow) when there's only one job in the workflow, as the context makes it clear enough.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1994
File: crates/common/src/raindex_client/vaults.rs:282-292
Timestamp: 2025-07-15T08:01:38.534Z
Learning: In the rainlanguage/rain.orderbook codebase, findolor prefers to avoid concurrency optimizations like using `futures::future::try_join_all` for parallel processing of balance changes, considering such optimizations "not that critical at the moment" when the performance impact is minimal.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:24:53.708Z
Learning: For PR #1884 in rainlanguage/rain.orderbook, provide a separate comment after each review with PR size statistics in the format: `TOTAL=number ADDITIONS=number DELETIONS=number`, excluding lock files like package-lock.json and cargo.lock.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1956
File: crates/common/src/fuzz/mod.rs:64-64
Timestamp: 2025-07-04T09:02:57.301Z
Learning: In rainlanguage/rain.orderbook, user findolor prefers to limit type consistency changes to only the parts directly related to the current work scope. For example, when updating chain_id fields from u64 to u32 in fuzz-related code, unrelated files like tauri-app wallet commands can remain as u64 if they serve different purposes and aren't part of the current changes.

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 2117
File: crates/js_api/src/gui/select_tokens.rs:421-424
Timestamp: 2025-09-02T08:04:34.729Z
Learning: User findolor in the rainlanguage/rain.orderbook codebase prefers not to change test code when tests are already passing, even if there appear to be type mismatches or potential issues. Working tests should be left alone unless there are actual errors.

Learnt from: rouzwelt
Repo: rainlanguage/rain.orderbook PR: 0
File: :0-0
Timestamp: 2025-05-21T21:26:31.566Z
Learning: For PR #1884 and future PRs in rainlanguage/rain.orderbook repository, provide PR size reports in a separate comment with ONLY the exact format "TOTAL=number\nADDITIONS=number\nDELETIONS=number", without any additional text or explanation. Reports should exclude irrelevant files such as lock files (package-lock.json, yarn.lock, pnpm-lock.yaml, cargo.lock).

Learnt from: findolor
Repo: rainlanguage/rain.orderbook PR: 1913
File: Cargo.toml:55-55
Timestamp: 2025-06-06T16:38:04.182Z
Learning: In rain.orderbook repository, during PR chains involving dependency updates, wasm-bindgen-utils may temporarily point to git commits that don't contain the full required functionality, with the understanding that subsequent PRs in the chain will update it to the correct commit.

findolor added 3 commits November 6, 2025 16:09

Move order-related local DB logic to be under local DB directory

b161286

Refactor fetch orders query to be more performant

6ce5838

Refactor trades tests

d7b2957

findolor added this to the LocalDB Implementation milestone Nov 6, 2025

findolor requested review from 0xgleb and hardyjosh November 6, 2025 15:15

findolor self-assigned this Nov 6, 2025

findolor added 4 commits November 10, 2025 11:40

Merge branch 'local-db-sidebar' into local-db-orders-query

2b0aa09

refactor

8a72f9c

update settings hash

c65a66d

Merge branch 'local-db-sidebar' into local-db-orders-query

b371c08

findolor mentioned this pull request Nov 12, 2025

Update fetch vaults query performance #2313

Closed

4 tasks

Merge branch 'local-db-sidebar' into local-db-orders-query

e219ad6

findolor mentioned this pull request Nov 17, 2025

Use proper types for addresses and bytes for local db related logic #2318

Merged

4 tasks

fix tests

d596428

0xgleb approved these changes Nov 25, 2025

View reviewed changes

Merge branch 'local-db-sidebar' into local-db-orders-query

3ab2236

hardyjosh approved these changes Nov 30, 2025

View reviewed changes

Base automatically changed from local-db-sidebar to main December 1, 2025 08:43

Merge branch 'main' into local-db-orders-query

5f129fe

findolor mentioned this pull request Dec 1, 2025

Refactor local DB data fetching for RaindexClient #2341

Merged

4 tasks

findolor merged commit 9530645 into main Dec 1, 2025
20 checks passed

findolor deleted the local-db-orders-query branch December 1, 2025 16:04

coderabbitai Bot mentioned this pull request Feb 15, 2026

feat: signed context oracle fetch module (Phase 3) #2458

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update fetch orders query performance #2304

Update fetch orders query performance #2304
findolor merged 11 commits intomainfrom
local-db-orders-query

findolor commented Nov 6, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Nov 6, 2025 •

edited

Loading

Uh oh!

findolor commented Nov 17, 2025

Uh oh!

coderabbitai Bot commented Nov 17, 2025

Uh oh!

0xgleb Nov 17, 2025

Uh oh!

0xgleb Nov 17, 2025

Uh oh!

0xgleb Nov 17, 2025

Uh oh!

Uh oh!

github-actions Bot commented Dec 1, 2025

Uh oh!

coderabbitai Bot commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

findolor commented Nov 6, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Chained PR

Motivation

Solution

Checks

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Pre-merge checks and finishing touches

Uh oh!

findolor commented Nov 17, 2025

Uh oh!

coderabbitai Bot commented Nov 17, 2025

Uh oh!

0xgleb Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

0xgleb Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

0xgleb Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Dec 1, 2025

S/M/L PR Classification Guidelines:

Small (S)

Medium (M)

Large (L)

Additional Factors to Consider

Notes:

Uh oh!

coderabbitai Bot commented Dec 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

findolor commented Nov 6, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Nov 6, 2025 •

edited

Loading