Skip to content

Update fetch vaults query performance#2313

Closed
findolor wants to merge 43 commits intomainfrom
local-db-vaults-query
Closed

Update fetch vaults query performance#2313
findolor wants to merge 43 commits intomainfrom
local-db-vaults-query

Conversation

@findolor
Copy link
Copy Markdown
Collaborator

@findolor findolor commented Nov 11, 2025

Chained PR

Motivation

Just like the orders query we needed to update the fetch_calls query to execute everything in a single database call. This PR aims to improve the query performance by adding that.

Solution

  • Move local_db related vault logic to be under local_db directory
  • Remove the unused fetch_vault query
  • Update fetch_vaults query to accept a list of chain ids and orderbook addresses
  • Update Vault balance changes query fix the missing row issue
  • Move and update tests

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@findolor findolor added this to the LocalDB Implementation milestone Nov 11, 2025
@findolor findolor requested review from 0xgleb and hardyjosh November 11, 2025 08:19
@findolor findolor self-assigned this Nov 11, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 11, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch local-db-vaults-query

Comment @coderabbitai help to get the list of available commands and usage tips.

Base automatically changed from local-db-orders-query to main December 1, 2025 16:04
@findolor findolor closed this Dec 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant