Skip to content

Fix web locks API leadership guard logic#2314

Closed
findolor wants to merge 2 commits intolocal-db-vaults-queryfrom
local-db-web-lock-api
Closed

Fix web locks API leadership guard logic#2314
findolor wants to merge 2 commits intolocal-db-vaults-queryfrom
local-db-web-lock-api

Conversation

@findolor
Copy link
Copy Markdown
Collaborator

@findolor findolor commented Nov 11, 2025

Chained PR

Motivation

In our implementation whenever we opened up a new tab, instead of returning a non-value or an error value for an unavailable lock, it was holding onto it making the tab stuck in the acquiring process. This PR aims to fix that by failing fast and making sure the type can exit out of the sync process.

Solution

  • Use the correct parameters when calling requests

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs
  • included screenshots (if this involves a front-end change)

@findolor findolor added this to the LocalDB Implementation milestone Nov 11, 2025
@findolor findolor requested review from 0xgleb and hardyjosh November 11, 2025 08:22
@findolor findolor self-assigned this Nov 11, 2025
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Nov 11, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch local-db-web-lock-api

Comment @coderabbitai help to get the list of available commands and usage tips.

@findolor findolor closed this Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant