Skip to content

fix(soldeer): ignore .cargo, .devcontainer.json, .prettierignore - #500

Merged
thedavidmeister merged 1 commit into
mainfrom
2026-05-14-soldeerignore-fix
May 14, 2026
Merged

fix(soldeer): ignore .cargo, .devcontainer.json, .prettierignore#500
thedavidmeister merged 1 commit into
mainfrom
2026-05-14-soldeerignore-fix

Conversation

@thedavidmeister

@thedavidmeister thedavidmeister commented May 14, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add three tracked dotfiles to `.soldeerignore` so soldeer's check_dotfiles stops blocking the publish.
  • v0.1.0 tag's publish run failed with the standard `Error: Failed to run soldeer: error during IO operation for "": not connected` (sensitive-files warning waiting for TTY confirmation).
  • After merge: tag v0.1.1 to re-fire the publish workflow.

Test plan

  • `forge soldeer push rain-interpreter~0.1.0 --dry-run` locally — zip contains no leading-dot entries.
  • v0.1.1 publish workflow succeeds and rain-interpreter lands on soldeer.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated repository ignore patterns to exclude additional internal configuration files and tooling artifacts from distribution.

Review Change Stack

These tracked dotfiles tripped soldeer's check_dotfiles warning, blocking the v0.1.0 publish. Dry-run zip now contains no leading-dot entries.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@thedavidmeister thedavidmeister self-assigned this May 14, 2026
@coderabbitai

coderabbitai Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c0da4ab9-4452-4d86-8715-2ec8c27cc2e7

📥 Commits

Reviewing files that changed from the base of the PR and between 7ef5967 and 2ffb07b.

📒 Files selected for processing (1)
  • .soldeerignore

📝 Walkthrough

Walkthrough

This PR updates .soldeerignore to exclude additional repository root files and directories from Soldeer's dependency processing, including dotfiles (.cargo, .coderabbit.yaml, .devcontainer.json, .envrc, .gas-snapshot, .github), configuration files (.pre-commit-config.yaml, .prettierignore), and tool-generated directories (/.cache, /.dependencies, /.deployments, /.meta).

Changes

Soldeerignore Configuration

Layer / File(s) Summary
Soldeerignore pattern expansion
.soldeerignore
Ignore patterns are added for additional repository root dotfiles and directories including .cargo, .coderabbit.yaml, .devcontainer.json, .envrc, .gas-snapshot, .github, and common tooling outputs such as .pre-commit-config.yaml and tool-generated folders.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 With tail held high and whiskers twitching,
I've cleaned the ignore list—no more glitching!
.cargo and .cache now safely tucked away,
Soldeer hops cleaner through the day.
What once was messy, now is neat,
A tidy config—can't be beat! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions three specific files (.cargo, .devcontainer.json, .prettierignore) but the changeset also adds several other ignore patterns (e.g., .coderabbit.yaml, .envrc, .gas-snapshot, .github, .pre-commit-config.yaml, and directory patterns like /.cache, /.dependencies, /.deployments, /.meta), making the title incomplete. Update the title to be more comprehensive, such as 'fix(soldeer): expand .soldeerignore to exclude development and tooling files' or verify if only the three mentioned files were intended to be added.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-05-14-soldeerignore-fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@thedavidmeister
thedavidmeister merged commit d49afe3 into main May 14, 2026
7 of 8 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

@coderabbitai assess this PR size classification for the totality of the PR with the following criterias and report it in your comment:

S/M/L PR Classification Guidelines:

This guide helps classify merged pull requests by effort and complexity rather than just line count. The goal is to assess the difficulty and scope of changes after they have been completed.

Small (S)

Characteristics:

  • Simple bug fixes, typos, or minor refactoring
  • Single-purpose changes affecting 1-2 files
  • Documentation updates
  • Configuration tweaks
  • Changes that require minimal context to review

Review Effort: Would have taken 5-10 minutes

Examples:

  • Fix typo in variable name
  • Update README with new instructions
  • Adjust configuration values
  • Simple one-line bug fixes
  • Import statement cleanup

Medium (M)

Characteristics:

  • Feature additions or enhancements
  • Refactoring that touches multiple files but maintains existing behavior
  • Breaking changes with backward compatibility
  • Changes requiring some domain knowledge to review

Review Effort: Would have taken 15-30 minutes

Examples:

  • Add new feature or component
  • Refactor common utility functions
  • Update dependencies with minor breaking changes
  • Add new component with tests
  • Performance optimizations
  • More complex bug fixes

Large (L)

Characteristics:

  • Major feature implementations
  • Breaking changes or API redesigns
  • Complex refactoring across multiple modules
  • New architectural patterns or significant design changes
  • Changes requiring deep context and multiple review rounds

Review Effort: Would have taken 45+ minutes

Examples:

  • Complete new feature with frontend/backend changes
  • Protocol upgrades or breaking changes
  • Major architectural refactoring
  • Framework or technology upgrades

Additional Factors to Consider

When deciding between sizes, also consider:

  • Test coverage impact: More comprehensive test changes lean toward larger classification
  • Risk level: Changes to critical systems bump up a size category
  • Team familiarity: Novel patterns or technologies increase complexity

Notes:

  • the assessment must be for the totality of the PR, that means comparing the base branch to the last commit of the PR
  • the assessment output must be exactly one of: S, M or L (single-line comment) in format of: SIZE={S/M/L}
  • do not include any additional text, only the size classification
  • your assessment comment must not include tips or additional sections
  • do NOT tag me or anyone else on your comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant