fix: bundle core.js in the deploy (live site was 404'ing it) - #4
Merged
Conversation
When core.js was added, index.html started loading it but the Pages deploy (pages.yml) and the release zip (web.yml) copy a hardcoded file list that didn't include it. The deployed bundle therefore 404'd on core.js and app.js crashed at the first call (rotFor is not defined), leaving pods unpositioned and all buttons dead. - Add core.js (and the previously-omitted dfu.js) to the deploy + release bundles. - Add a guard to the deploy: every <script src> in index.html must exist in _site/, or the build fails. This catches a missing bundled asset that the repo-level CI checks (parse, Prettier, ESLint, unit tests) can't — they validate the source tree, not the deployed set. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
When core.js was added, index.html started loading it but the Pages deploy (pages.yml) and the release zip (web.yml) copy a hardcoded file list that didn't include it. The deployed bundle therefore 404'd on core.js and app.js crashed at the first call (rotFor is not defined), leaving pods unpositioned and all buttons dead.
Checklist
CONFIGblock matchesspore/docs/MIDI_PROTOCOL.md