feat: drop the hold-both-footswitches DFU gesture - #5
Merged
Conversation
DFU is reachable over MIDI (CC 119 >= 64) and via the Seed's BOOT+RESET buttons, so the footswitch gesture is redundant -- and removing it frees the footswitch combinations for upcoming features (presets). Only the call site in main.cpp is removed; the vendored Hothouse proxy is untouched, and --gc-sections drops the now-unused method (~0.9 KB flash reclaimed). Docs/comments updated (README, params.h, flash scripts, architecture SVG). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DFU is reachable over MIDI (CC 119 >= 64) and via the Seed's BOOT+RESET buttons, so the footswitch gesture is redundant -- and removing it frees the footswitch combinations for upcoming features (presets). Only the call site in main.cpp is removed; the vendored Hothouse proxy is untouched, and --gc-sections drops the now-unused method (~0.9 KB flash reclaimed). Docs/comments updated (README, params.h, flash scripts, architecture SVG).
What this changes
Checklist
src/config/params.hdocs/MIDI_PROTOCOL.mdand theparams::midimap