Skip to content

Stabilize VS Code extension npm test runs#670

Merged
rajbos merged 1 commit intomainfrom
rajbos/fix-chat-leakage
Apr 24, 2026
Merged

Stabilize VS Code extension npm test runs#670
rajbos merged 1 commit intomainfrom
rajbos/fix-chat-leakage

Conversation

@rajbos
Copy link
Copy Markdown
Owner

@rajbos rajbos commented Apr 24, 2026

This fixes the Windows-side hang we were seeing around the VS Code extension npm workflows. The underlying issue was not the unit tests themselves - the compiled test files pass - but the way the npm scripts combined nested npm run ... wrappers, inline shell snippets, npm progress UI, and a single wildcard node --test invocation.

The change makes the npm path more predictable and non-interactive:

  • disable npm progress/funding prompts in vscode-extension/.npmrc
  • flatten the compile, package, pretest, and test:node script chains so they invoke the real commands directly instead of nesting more npm wrappers
  • move test-output preparation into a reusable scripts/prepare-test-output.js helper instead of an inline node -e fragment
  • run compiled node unit tests sequentially via scripts/run-node-unit-tests.js, emitting compact per-file PASS output and only dumping full child output on failure

The important behavior change is that npm ci, npm run compile, and npm run test:node now return cleanly in this environment instead of leaving the shell session looking stuck after the actual work has finished.

I left the coverage scripts on the existing single-process Node coverage path, aside from sharing the same test-output preparation step, because their behavior is tied to Node's coverage flags and this PR is focused on fixing the hanging standard workflow.

Disable npm progress output for the VS Code extension, flatten nested npm script wrappers, and move test preparation into reusable helper scripts.

Run compiled node unit tests sequentially so npm run test:node exits cleanly on this Windows environment instead of hanging behind the wildcard runner.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rajbos rajbos merged commit 3a8a3fc into main Apr 24, 2026
17 checks passed
@rajbos rajbos deleted the rajbos/fix-chat-leakage branch April 24, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant