Fix bugwarrior issue #393#109
Merged
ralphbean merged 2 commits intoralphbean:developfrom Oct 28, 2016
Merged
Conversation
It removes all control characters from a binary string ('bytes' in python
3) except the ones that are printable-ish that we might want to keep
around ("\t\n\v\f\r").
Also adds unit tests for the new function
Remove the control characters in the command executed in TaskWarriorShellout._execute. Also add some integration test for the task_add method to make sure that this fixes issue GothenburgBitFactory/bugwarrior#393.
Owner
|
Sorry for letting this sit for so long. LGTM! |
Contributor
Author
|
No problem. If you still plan to release bugwarrior soon, maybe do taskw as well to fix the issue with null characters. |
Owner
|
Done! https://pypi.python.org/pypi/taskw :) |
Contributor
Author
|
Thanks! I'll close GothenburgBitFactory/bugwarrior#393 then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the control characters in the command executed in
TaskWarriorShellout._execute.Also add some integration test for the task_add method to make sure that
this fixes issue GothenburgBitFactory/bugwarrior#393.