Skip to content

v0.1.2

Choose a tag to compare

@rameerez rameerez released this 16 Sep 19:21
· 56 commits to main since this release

0.1.1 was packaged from the wrong tree. This is the release it should have been.

The gem published to rubygems as 0.1.1 does not declare verified: true on SupportDesk::Desk, so no desk is badged — while its release notes said that was the entire point of the release.

The repository was correct the whole time. The tag, main, and every test all carried the change; only the package did not. That is the worst shape this mistake can take: nothing in git looks wrong, and the suite passes, because the suite runs against the repository rather than against what was shipped.

What changed

  • SupportDesk::Desk declares verified: true, so SupportDesk::Desk.chat_verified? is true and every desk carries the official-account mark in the inbox row, the grouped row and the thread header.

  • A guard test asks the loaded class, not the source file:

    assert SupportDesk::Desk.chat_verified?,
           "SupportDesk::Desk is not verified — if the repo source says it is, " \
           "the loaded gem was built from a different tree"

    Run inside a packaged gem, that reads the packaged file. A build from a stale tree now fails instead of shipping quietly.

If you installed 0.1.1

Upgrade. Nothing else is different, there is no migration and no API change: you get the badge that 0.1.1 promised.

Verified

Tests 647 runs, 2945 assertions, 0 failures
Databases SQLite, PostgreSQL
Rails 7.2, 8.0, 8.1
Lint / security rubocop clean, brakeman 0 warnings
The package itself unpacked and checked: carries verified: true

Requires chats ~> 0.3.

Full Changelog: v0.1.1...v0.1.2