Conversation
This pins the cache action to its commit: 0400d5f644dc74513175e3cd8d07132dd4860809 Which is https://github.com/actions/cache/releases/tag/v4.2.4 This allows people to enable the strict GitHub setting to only run pinned GitHub Actions. See https://docs.github.com/en/organizations/managing-organization-settings/disabling-or-limiting-github-actions-for-your-organization#managing-github-actions-permissions-for-your-organization
|
Ha! I was just about to open a PR for this, but luckily noticed this PR already being open. Would be great if this could be released as a new @ramsey If it helps, the below is the commit message I'd written to argue the case for making/accepting this change.
|
|
I'm very sorry for just now seeing this. I need to review how my notifications work because I'm clearly not getting them (via email or otherwise). Is it better to use the hash, or can you use the tag? In other words, what's the difference between this: and this: If there's no difference, I prefer to use the tag name. What's the process for upgrading to a new version look like? This seems like undue burden on the upstream maintainers for having to update their version numbers to ensure downstream users remain secure. Isn't that why version "ranges" (i.e., I guess the problem here is that GitHub (or someone else) could release an action with a critical security flaw and no one is aware of it until after many have been compromised? It seems like GitHub should implement lockfiles for actions, so downstream users can lock themselves to a specific version of all their action dependencies, but I digress... I'll accept this. I'm just curious whether the actual hash is preferred over the specific tag name. |
|
One more question: since this PR was created, GitHub has released a number of other versions, including 5.0.0, and they are now at 5.0.3. Should I use the hash for the latest version instead, or should I stick with this hash for version 4.2.4? |
Ah. @jrfnl, I see now why the hash is important and the tag name won't work. |
Updates will be pulled by Dependabot, as usual. For this to work, the This also means that Dependabot updates will now likely come with a much higher frequency. That makes it easier to manage the flood of PRs. Alternatively, you can locally use the
💯 (and I happen to know they are working on something like this is in the background) Basically, GHA is a system which was set up for use with private repos and then made public. It was never designed with security in mind and they are now scrambling to catch up (and giving maintainers a shitload of work to secure workflows in the mean time). @ramsey Hope this explains things a little more! |
@ramsey Now this PR has been merged and knowing that the action runner is out of date.... you should be able to manually trigger a Dependabot run on the https://github.com/ramsey/composer-install/network/updates page. If that creates a PR to update to the |
|
@jrfnl Looks like it works: |
Hashes are a good choice, but once Immutable Releases are enabled in that repo I would prefer to see a tag pin instead. |
Description
This pins the cache action to its commit:
0400d5f644dc74513175e3cd8d07132dd4860809
Which is https://github.com/actions/cache/releases/tag/v4.2.4
Motivation and context
This allows people to enable the strict GitHub setting to only run pinned GitHub Actions. See https://docs.github.com/en/organizations/managing-organization-settings/disabling-or-limiting-github-actions-for-your-organization#managing-github-actions-permissions-for-your-organization
How has this been tested?
This did not change anything really, but was tested internally in our workflows.
Types of changes
PR checklist