Use K3S host cluster for E2E tests#492
Conversation
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #492 +/- ##
==========================================
+ Coverage 53.21% 57.02% +3.80%
==========================================
Files 53 56 +3
Lines 6459 6559 +100
==========================================
+ Hits 3437 3740 +303
+ Misses 2763 2550 -213
- Partials 259 269 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
enrichman
left a comment
There was a problem hiding this comment.
Thank you! As agreed I would use the make test-e2e command to just run the tests, on the targeted cluster. I would not use it to install (we already have a command for that).
I'm just thinking if we could avoid the E2E_KUBECONFIG var and use simply the current KUBECONFIG. If we are just running the tests it should be fine, and also it will be more predictable and easy to understand. If I'm an external user I would need to know that I need to export this particular variable, but maybe it's easier to just use what I am targeting. Also because if I am using the make install to update the installation of K3k I will need to remember that they are pointing to different variable. A bit confusing IMHO. Wdyt?
NIT: please add a small description to the PRs!
There was a problem hiding this comment.
I think this file was not supposed to be committed.
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
Signed-off-by: galal-hussein <hussein.galal.ahmed.11@gmail.com>
enrichman
left a comment
There was a problem hiding this comment.
This was a great one! Thanks Hussein, love it!
The PR uses k3s as a host cluster for e2e tests instead of using docker, docker now should be optional to use by setting environment variable
K3K_DOCKER_INSTALL