Added the possibility to enable or disable ECC#566
Closed
scogliani wants to merge 11 commits into
Closed
Conversation
Owner
|
I went back and forth on your approach for some time, but overall it offers excellent control to the builder of the library as to which curves are included without too much extra noise. So if you update the tests to handle missing curves, this change works for me. |
added 10 commits
August 16, 2016 15:27
Owner
|
Closing this due to inactivity and lots of conflicts. Still would be useful to have this functionality but given the massive refactorings that have happened in EC_Group since 2.4.0 I expect we'll want to go with a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As asked in #551, I added folders for each ECC with an info.txt and some preprocessings checking, allowing the behave of disabling or enabling specific curves. For the moment I just changed test_ecc_pointmul. If this approach seems relevant, I will continue for the other test programs.