fix(infra): JARL1188 — detach the /ssr/* behaviour so the VPC origin can be updated - #116
Merged
Merged
Conversation
…can be updated CloudFront rejects an update to a VPC origin while a distribution is still associated with it, so the distribution has to let go before the origin can be repointed. Drop the behaviour and order JarlSsr after JarlStaticSite; a later deploy attaches it again. Ticket: 1188
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 1 of two: detach only.
Before merging: confirm
JarlSsrsits atUPDATE_ROLLBACK_COMPLETErather thanUPDATE_ROLLBACK_FAILED— a wedged stack fails every later deploy for reasons that look unrelated./ssr/*behaviour, so nothing is associated with the VPC origin./ssr/*then falls through to the distribution's static 404 until phase 2 reattaches it, which is what it effectively serves today.JarlSsris deliberately unchanged: its synthesized resources and exports are byte-identical tomaster, differing only by two now-unreferencedFn::GetStackOutputoutputs. TheAWS::CloudFront::VpcOriginitself survives.JarlSsris ordered afterJarlStaticSiteso the detach lands first — which also lets the origin repointmasteralready carries finally apply, since nothing is attached by then.