fix: omo-system-reminder filter strips blocks, preserves user content - #271
Merged
Merged
Conversation
Filter v1.2.0 returned { action: "drop" } for ANY user message containing
<system-reminder> blocks, even when user text was also present. Phase 2
keepLastOnly then hard-dropped older matches entirely — losing the user's
actual message content.
Two fixes:
1. Filter v1.3.0: strip <system-reminder> blocks, return modify when user
content remains, drop only for pure OMO messages (no user text)
2. Phase 2: apply filter's actual decision for older matches instead of
unconditional drop — strips stale blocks while preserving user text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: Filter drops user content with
<system-reminder>blocksProblem
The
omo-system-reminderfilter (v1.2.0) returned{ action: "drop" }for ANY user message containing<system-reminder>blocks — even when user text was also present. Phase 2keepLastOnlythen hard-dropped older matches entirely, losing the user's actual message content.Fix (2 changes)
1. Filter v1.3.0: Strip
<system-reminder>blocks, returnmodifywhen user content remains,droponly for pure OMO messages.2. Phase 2: Apply filter's actual decision for older matches instead of unconditional drop.
Tests