catch mt940-errors when getting transactions#48
Closed
marcelb98 wants to merge 1 commit intoraphaelm:masterfrom
Closed
catch mt940-errors when getting transactions#48marcelb98 wants to merge 1 commit intoraphaelm:masterfrom
marcelb98 wants to merge 1 commit intoraphaelm:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
- Coverage 89.17% 89.16% -0.01%
==========================================
Files 23 23
Lines 2966 2982 +16
==========================================
+ Hits 2645 2659 +14
- Misses 321 323 +2
Continue to review full report at Codecov.
|
Owner
|
I think we can close this as the bug in mt940 seems to be fixed and this seems to be a very special-case API |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually importing transactions is crashing if the MT940 sent by the bank is not correct. Depending on what was wrong in the MT940 you'll get another exception of the mt940 library. I've submitted some examples of malformed MT940 in wolph/mt940#65
This PR adds an alternative for the
get_transactions()function which catches those exceptions.It returns the statements which were correct and could be parsed on the one hand and the malformed MT940-strings coupled with the thrown exception on the other hand.
With those caught errors it's possible to review the MT940 and rerun the parser later.