feat(web): add favicon icon#8
Merged
raphaelsalaja merged 2 commits intomainfrom Apr 23, 2026
Merged
Conversation
Adds a programmatic favicon at app/icon.tsx using next/og's ImageResponse. The icon mirrors the top-nav logo: a music note rendered on a circular ds-gray-3 background with a ds-gray-8 fill, keeping branding consistent across the browser tab and the in-app logo. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The file is already listed in .gitignore but was tracked from before the ignore rule was added. Next.js rewrites this file between dev and build runs (e.g. ./.next/types/routes.d.ts vs ./.next/dev/types/routes.d.ts), producing noisy diffs that should never be committed. Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Adds a programmatically generated favicon route for the Next.js app (/icon) so the site gets a consistent tab icon without committing static .ico/.png assets.
Changes:
- Introduces
apps/web/app/icon.tsxusingnext/og’sImageResponseto render a 32×32 PNG favicon. - Renders a music-note SVG on a circular background to match the in-app branding.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
+32
| background: "#ebebeb", | ||
| borderRadius: "50%", | ||
| }} | ||
| > | ||
| <svg | ||
| width="18" | ||
| height="18" | ||
| viewBox="0 0 18 18" | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| aria-label="Music note" | ||
| > | ||
| <path | ||
| d="M13.014,1.162l-3.5,.477h0c-.862,.118-1.513,.864-1.513,1.734v7.262c-.568-.398-1.256-.635-2-.635-1.93,0-3.5,1.57-3.5,3.5s1.57,3.5,3.5,3.5,3.5-1.57,3.5-3.5V6.405l3.987-.543c.862-.118,1.513-.864,1.513-1.734v-1.231c0-.505-.218-.986-.599-1.318-.381-.333-.894-.484-1.387-.416Z" | ||
| fill="#8f8f8f" | ||
| /> |
Comment on lines
+29
to
+31
| <path | ||
| d="M13.014,1.162l-3.5,.477h0c-.862,.118-1.513,.864-1.513,1.734v7.262c-.568-.398-1.256-.635-2-.635-1.93,0-3.5,1.57-3.5,3.5s1.57,3.5,3.5,3.5,3.5-1.57,3.5-3.5V6.405l3.987-.543c.862-.118,1.513-.864,1.513-1.734v-1.231c0-.505-.218-.986-.599-1.318-.381-.333-.894-.484-1.387-.416Z" | ||
| fill="#8f8f8f" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/web/app/icon.tsxusingnext/og'sImageResponse, picked up automatically by Next.js as the<link rel="icon">for the site.MusicNotelogo: same SVG path, on a circular background using the same Geist tokens (--ds-gray-3background,--ds-gray-8fill) for consistency between the browser tab and the in-app logo.Test plan
pnpm --filter @web-kits/website devand confirm the favicon appears in the browser tab./icondirectly and verify the generated PNG renders the music note in a grey circle.<head>and confirm<link rel="icon" href="/icon?..." type="image/png" sizes="32x32" />is present.Made with Cursor