smb_enumshares (Metasploit framework 4.17.21-dev)

[hackerfive]

use auxiliary/scanner/smb/smb_enumshares

Options:
ShowFiles = true
SpiderShares = true

The options above, are not working on Kali 2018.4, Metasploit framework 4.17.21-dev
If you using an older version of Kali, like: 2018.1 (Metasploit framework 4.16.30-dev) / 2018.2 / 2018.3 the options do work.

[bcoles]

I've verified this is an issue on latest msf5 branch.

On Metasploit 4.16.19-dev the spidering works as expected.

On latest Metasploit, the module lists the root shares, then halts, reporting no errors.

However, set VERBOSE true reveals that an error was thrown and silently swallowed:

[-] 123.45.67.89:445        - Error: '123.45.67.89' 'RubySMB::Error::UnexpectedStatusCode' 'STATUS_ACCESS_DENIED'

The error handing happens here in modules/auxiliary/scanner/smb/smb_enumshares.rb :

      rescue ::Exception => e
        next if e.to_s =~ /execution expired/
        next if not shares.empty? and rport == 139
        vprint_error("Error: '#{ip}' '#{e.class}' '#{e.to_s}'")

Presumably, a valid workaround would be:

      rescue ::Exception => e
        next if e.to_s =~ /execution expired/
        next if e.to_s =~ /STATUS_ACCESS_DENIED/
        next if not shares.empty? and rport == 139
        vprint_error("Error: '#{ip}' '#{e.class}' '#{e.to_s}'")

This patch is likely incomplete - there's likely to be other exceptions we would wish to handle gracefully.

Also, given that the vprint_error is only ever executed upon catastrophic failure, with no recovery, it should probably be changed to print_error.

[bcoles]

Closer inspection reveals that the issue is buried deep within the spaghetti.

[github-actions]

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

[adfoster-r7]

This doesn't appear to be an issue with Metasploit 6.x, tested against two different targets.

[github-actions]

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

[github-actions]

Hi again!

It’s been 60 days since anything happened on this issue, so we are going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.