[3.x] Merge the frontend config for all translations within a rapidez namespace#836
Closed
[3.x] Merge the frontend config for all translations within a rapidez namespace#836
Conversation
Jade-GG
reviewed
May 2, 2025
|
|
||
| $allTranslations = collect($loader->namespaces()) | ||
| ->filter(function (string $path, string $namespace): bool { | ||
| return str($namespace)->startsWith('rapidez'); |
Collaborator
There was a problem hiding this comment.
Is this not too restrictive? This would only allow official Rapidez packages to add frontend translations, right? What if a different vendor wants to make a package for Rapidez that includes frontend translations?
This was referenced May 2, 2025
Member
|
Closing, reference: RAP-729 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code will get every translation that is defined in a 'rapidez-*' namepsace within a frontend.php file. This will allow packages to add frontend translations with ease.
Docs; incoming