Submit forms with fetch with translations#137
Merged
Conversation
Closed
Jade-GG
approved these changes
May 2, 2025
Co-authored-by: Jade Geels <a@jgw.tf>
Co-authored-by: Jade Geels <a@jgw.tf>
indykoning
reviewed
May 6, 2025
| } | ||
| } else { | ||
| this.error = true | ||
| Notify(window.config.translations.packages.statamic.form.error, 'error') |
Member
There was a problem hiding this comment.
In some places in Rapidez we also log the error https://github.com/rapidez/core/blob/master/resources/js/fetch.js#L150
https://github.com/rapidez/core/blob/4ddd4d2c1fd0a3f6ae0f2dea81331a0a5ef7254a/resources/js/stores/useSwatches.js#L21
is that something we might want to do here?
…ms-ajax-translations
…statamic into feature/forms-ajax-translations
Member
Author
|
Added the discussed solution now. @royduin |
royduin
reviewed
May 20, 2025
| } | ||
| } else { | ||
| this.error = true | ||
| Notify(window.config.statamic.translations.form.error, 'success') |
Member
There was a problem hiding this comment.
Success? Shouldn't that be error or warning?
Jade-GG
approved these changes
May 21, 2025
indykoning
approved these changes
May 21, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This another take on #136 however this is completely dependent on this new functionality: rapidez/core#836
This has my preference over #136