Conversation
BobWez98
commented
May 2, 2025
| type: Object, | ||
| default: () => ({}), | ||
| }, | ||
| callback: { |
Member
Author
There was a problem hiding this comment.
Added a callback because in a project you might want to add some functionality like "closing a modal" or conversion tracking.
BobWez98
commented
May 2, 2025
| return { | ||
| formData: this.initialData, | ||
| success: false, | ||
| error: false, |
Member
Author
There was a problem hiding this comment.
The developer can use these to show/hide validation on the frontend apart from the notify.
Collaborator
|
I agree that #137 is nicer when the translations thing is merged 🙂 |
indykoning
reviewed
May 6, 2025
| } | ||
| } else { | ||
| this.error = true | ||
| Notify(this.translations.error, 'error') |
Member
There was a problem hiding this comment.
In some places in Rapidez we also log the error https://github.com/rapidez/core/blob/master/resources/js/fetch.js#L150
https://github.com/rapidez/core/blob/4ddd4d2c1fd0a3f6ae0f2dea81331a0a5ef7254a/resources/js/stores/useSwatches.js#L21
is that something we might want to do here?
Member
Author
|
As discussed this will be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a version with the translations being passed as prop. I will make a second PR whith a proposal for merging translations with Rapidez Core.
Also see #137 for a better handling of translations