Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Mar 20, 2021

No description provided.

@ghost
Copy link
Author

ghost commented Mar 20, 2021

I've also added a quick mention of what is required on the various models of compute module, which fixes #1754.

@aallan
Copy link
Contributor

aallan commented Jun 7, 2021

How does this relate to #1849?

@ghost
Copy link
Author

ghost commented Jun 7, 2021

How does this relate to #1849?

It's a reaction to #1849, which purports to solve #1754 but doesn't. This one does. #1849 also adds lots of extra verbage, and if it were up to me that would not get integrated.

I will leave this PR open should you decide it is worth integrating: it contains minor additions to add information which some forum users have requested, and minor corrections, and I believe it is ready to integrate as is.

@aallan aallan added the ready to merge The OP says this PR is ready to merge? Anyone object? label Jun 7, 2021
@aallan
Copy link
Contributor

aallan commented Jun 7, 2021

So for clarity, you're arguing this PR should be merged instead of #1849? So it's an either or? Thanks, that clarifies the situation!

@ghost
Copy link
Author

ghost commented Jun 7, 2021

So for clarity, you're arguing this PR should be merged instead of #1849?

That is indeed my position.

@aallan
Copy link
Contributor

aallan commented Jun 7, 2021

That is indeed my position.

Gotcha.

@aallan aallan linked an issue Jun 7, 2021 that may be closed by this pull request
@aallan aallan merged commit 2451d52 into raspberrypi:master Jul 10, 2021
@ghost ghost deleted the patch-11 branch July 10, 2021 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to merge The OP says this PR is ready to merge? Anyone object?

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UART: Enabling of UART1 for CM3+ does not work

1 participant