Report an environmental skip as TrialOutcome::skipped() - #39
Merged
Conversation
The engine counts a skip and a discard the same everywhere but the corpus phase, where a discard means "the recorded input left the property's domain" and the entry is pruned. `markTestSkipped()` guarding a missing dependency says nothing about the input, so folding it into a discard let a machine without that dependency delete the recorded counterexample for every machine that has it — silently and for good. Needs the seam core 0.8 added, so the constraint moves to ^0.8. Fixes #38
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: Warning Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Covering PhpUnitTrialExecutor directly pulled the whole class into the mutation map, where six of its mutants had never been mapped and now escaped. The behaviour that matters is not the flag anyway: a recorded regression must survive a replay this environment skipped. EnvironmentParityTest now records a falsification, replays it in a body that calls markTestSkipped(), and asserts the stored bytes are untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine counts a skip and a discard the same everywhere but the corpus
phase, where a discard means "the recorded input left the property's domain"
and the entry is pruned.
markTestSkipped()guarding a missing dependency saysnothing about the input, so folding it into a discard let a machine without
that dependency delete the recorded counterexample for every machine that has
it — silently and for good.
Needs the seam core 0.8 added, so the constraint moves to ^0.8.
Fixes #38