fix(utils): try to improve mobile detection#65
Merged
orhun merged 1 commit intoratatui:mainfrom Apr 1, 2025
Merged
Conversation
orhun
approved these changes
Mar 29, 2025
Member
orhun
left a comment
There was a problem hiding this comment.
Hey, nice!
Some questions:
- Did you run into an issue where the mobile isn't detected with the previous approach?
- What kind of fallbacks does this have?
Contributor
Author
|
Hey man, thanks for the review.
If you use a mobile browser and just change the device orientation to landscape, the old approach would claim the device is not a mobile anymore. To me, the function
The drawbacks of using the agent string are:
I think these drawbacks are acceptable, we just have to be aware of them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comes with its own set of drawbacks but maybe still a bit better than using the size 🤷