Merge yaib configs#12
Merged
manuelburger merged 54 commits intomainfrom Apr 3, 2024
Merged
Conversation
some values are only taken once during the hour and thus have a cnt=1 and rawdata=NA. The actual data is stored in Val, which otherwise holds the average. Since after expansion, rawdata is the main data field, the value from Val needs to be moved to rawdata in this case.
- Fix sic bugs - Slack temp range
Closed
…aib-configs # Please enter a commit message to explain why this merge is necessary,
Member
|
Can you rebase to get a reasonable diff? |
Collaborator
Author
I think right now the diff is fine without the rebase, no? |
Member
|
Top! IIUC these are mostly taken from YAIB / icuDG-preprocessing, whose authors I trust more on this than myself. Generally, I would like to see more comments, as all the callbacks are non-trival. But this should be done by the original author, so for anything copy-pasted that's ok. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
sicsupport fordeath_icuanddeath_hospsicsupport forlos_hospsicsupporturine_ratespo2andsao2fromo2satfor missing datasetspatient-idfor each dataset