Skip to content

feat(systemd): add unit inspection and override.conf editing - #260

Merged
ravindu644 merged 1 commit into
ravindu644:devfrom
omrxm18:feature/systemd-inspect-override
Aug 2, 2026
Merged

feat(systemd): add unit inspection and override.conf editing#260
ravindu644 merged 1 commit into
ravindu644:devfrom
omrxm18:feature/systemd-inspect-override

Conversation

@omrxm18

@omrxm18 omrxm18 commented Aug 1, 2026

Copy link
Copy Markdown
Contributor

Extends the systemd management screen beyond start/stop/restart:

  • ContainerSystemdManager: add inspectUnit() (systemctl show properties, status text, dependency tree) and getOverrideConf/setOverrideConf/ deleteOverrideConf, mirroring 'systemctl edit ' at /etc/systemd/system/.d/override.conf. Override writes go through the existing base64-streaming pattern to stay safe against shell injection via unit names.
  • InitServiceMenuAction: convert to a sealed class (Command / Navigate) so overflow-menu items can open a screen instead of only running a systemctl action. Updates OpenRCScreen/ProcdScreen call sites accordingly.
  • Add UnitDetailScreen and OverrideEditorScreen, wired into DroidspacesNavigation with two new routes.
  • SystemdScreen: add 'Inspect unit' and 'Edit override' to the per-service overflow menu.
  • Removed maxlines=1 and truncation of .service suffix (worse looking but needed for functionality)

Extends the systemd management screen beyond start/stop/restart:

- ContainerSystemdManager: add inspectUnit() (systemctl show properties,
  status text, dependency tree) and getOverrideConf/setOverrideConf/
  deleteOverrideConf, mirroring 'systemctl edit <unit>' at
  /etc/systemd/system/<unit>.d/override.conf. Override writes go through
  the existing base64-streaming pattern to stay safe against shell
  injection via unit names.
- InitServiceMenuAction: convert to a sealed class (Command / Navigate)
  so overflow-menu items can open a screen instead of only running a
  systemctl action. Updates OpenRCScreen/ProcdScreen call sites
  accordingly.
- Add UnitDetailScreen and OverrideEditorScreen, wired into
  DroidspacesNavigation with two new routes.
- SystemdScreen: add 'Inspect unit' and 'Edit override' to the
  per-service overflow menu.
@omrxm18
omrxm18 changed the base branch from main to dev August 1, 2026 08:09

@ravindu644 ravindu644 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localize strings in the inspect unit page.

@ravindu644

Copy link
Copy Markdown
Owner

nvm, I'll do that

@ravindu644
ravindu644 merged commit b5d4f34 into ravindu644:dev Aug 2, 2026
4 checks passed
@omrxm18
omrxm18 deleted the feature/systemd-inspect-override branch August 2, 2026 09:44
@omrxm18

omrxm18 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

Yo why the rush, I was asleep 😅

Anyways thanks for doing it

@ravindu644

Copy link
Copy Markdown
Owner

Yo why the rush, I was asleep 😅

Anyways thanks for doing it

Time matters in the weekend 😅😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants