Conversation
Aggregate rename conflicts into one multi-line WARN with old→new detail lines (simple-name, ancestor-nested, object-factory). Log each applied rename at DEBUG and keep INFO as a count only. Enrich invalid mapping warnings with the rule pattern.
Use DEBUG for each flatten with Owner.prop → Wrapper, INFO summaries with counts for flatten/remove, and multi-line WARN for kept wrappers (with reason) and stale annotation owners after later model merges.
Replace string concatenation with String.formatted for conflict detail lines and arrow formatting; keep SLF4J placeholders for actual log calls.
Keep INFO as the removed count only; emit the class list at DEBUG so default Maven builds stay quiet while details remain available when debugging.
Log each accepted merge and enum merge at DEBUG with victim → host form; keep INFO for merge and element-class-clear counts only. Aggregate ObjectFactory collisions into one multi-line WARN.
…style Log each successful one-level lift at DEBUG as type (from → to); keep INFO as the hop count only. Polish ObjectFactory skip wording for consistency.
…tyle Always log removed counts at INFO and name lists at DEBUG; drop the custom -verbose flag in favor of SLF4J levels. Update the test and wiki accordingly.
…apper style Log each successful property split at DEBUG as Owner.prop → [fields]; keep INFO as the flatten count only.
fix(rename-class): improve conflict and rename log readability
fix(element-wrapper): align logging style (INFO count, DEBUG detail)
fix(dedupe-class): align logging with rename/element-wrapper style
fix(promote-nested-class): align logging style
fix(remove-unused-class): align logging; drop -verbose flag
…ogging fix(flatten-multi-element-prop): align logging style
Capture element FQCNs before clearing className in dedupe; log renames and conflict arrows with full names; DEBUG only fields actually added by flatten; use labeled wrapper wording in element-wrapper DEBUG lines.
Log each property rename at DEBUG as Owner.prop → newName; keep INFO as the rename count only. Document logging in the class Javadoc.
fix(plugins): address logging review findings
…gging fix(rename-multi-element-prop): align logging style
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Standardize logging across model-mutating plugins:
SAXParseExceptionstack spam under the Maven pluginPlugins
-verbose; use SLF4J levels)Also
classNamein dedupe; accurate flatten DEBUG for partial adds; clearer conflict/rename labelsTest plan