[core] Remove test_get_locations_timeout - #54367
Merged
Merged
Conversation
dayshah
reviewed
Jul 7, 2025
dayshah
left a comment
dayshah
left a comment
Contributor
There was a problem hiding this comment.
I think this is actually extra busted and this won't help
The put will add to the reference counter synchronously from the python thread. So it's actually always there by the time you call get_object_locations
get_object_locations will actually make an rpc to itself and if that self rpc finishes before the future.wait_for(0), the test will fail
See CoreWorker::Put and CoreWorker::GetLocationFromOwner
I have this draft i made a while ago to avoid the self rpc #53322. Also want to combine get_local_object_locations and get_object_locations
…es/deflake-locations
…es/deflake-locations
edoakes
changed the title
test_get_locationstest_get_locations_timeout
dayshah
approved these changes
Jul 7, 2025
edoakes
enabled auto-merge (squash)
July 7, 2025 20:09
ccmao1130
pushed a commit
to ccmao1130/ray
that referenced
this pull request
Jul 29, 2025
This test sometimes fails because the location info _is_ available: https://buildkite.com/ray-project/postmerge/builds/11255#0197d1e5-5ee0-4b16-b852-4ee17b39cc10 The entire implementation is problematic, and after data [migrates](ray-project#53942) to `get_local_object_locations`, `get_object_locations` will be deleted. So for now deleting the flaky test. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: ChanChan Mao <chanchanmao1130@gmail.com>
dstrodtman
pushed a commit
to dstrodtman/ray
that referenced
this pull request
Oct 6, 2025
This test sometimes fails because the location info _is_ available: https://buildkite.com/ray-project/postmerge/builds/11255#0197d1e5-5ee0-4b16-b852-4ee17b39cc10 The entire implementation is problematic, and after data [migrates](ray-project#53942) to `get_local_object_locations`, `get_object_locations` will be deleted. So for now deleting the flaky test. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Signed-off-by: Douglas Strodtman <douglas@anyscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test sometimes fails because the location info is available: https://buildkite.com/ray-project/postmerge/builds/11255#0197d1e5-5ee0-4b16-b852-4ee17b39cc10
The entire implementation is problematic, and after data migrates to
get_local_object_locations,get_object_locationswill be deleted. So for now deleting the flaky test.