[core] Deflake test_task_metrics.py::test_pull_manager_stats - #63993
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to reduce flakiness in test_pull_manager_stats by counting both RUNNING and SUBMITTED_TO_WORKER states as running. Feedback includes a reminder to remove the temporary 50-trial parameterization before merging to avoid slow CI runs, and a suggestion to assert that only expected keys are present in stats since the length assertion was removed.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Ran the test many times on repeat in CI, no failures across ~20 runs: https://buildkite.com/ray-project/premerge/builds/67941 |
edoakes
changed the title
test_task_metrics.py::test_pull_manager_statstest_task_metrics.py::test_pull_manager_stats
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
…roject#63993) Loosen task state condition to include `SUBMITTED_TO_WORKER`. --------- Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com> Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
2 participants
Loosen task state condition to include
SUBMITTED_TO_WORKER.