[dashboard] Update axios to ^1.18.0 - #65130
Conversation
Signed-off-by: RinZ27 <222222878+RinZ27@users.noreply.github.com>
There was a problem hiding this comment.
Code Review
This pull request upgrades the axios dependency from version 0.21.x to 1.18.1 in the dashboard client. However, the changes in requestHandlers.ts attempt to import create as a named export from axios and call it directly. The reviewer correctly identified that axios does not support create as a named export, which will cause compilation or runtime errors, and recommended reverting to importing the default axios object and using axios.create().
|
@RinZ27, could you verify that all the usages of axios in our codebase are not affected by its breaking changes? |
|
I think the |
41a89c8 to
0a8f3f2
Compare
|
@sampan-s-nayak An automated bot previously suggested reverting the named |
|
Thanks @RinZ27 for working on this. I tried running a sample job locally with these changes and I am able to access different pages of the dashboard. merging this pr. |
## Description Re-opening of ray-project#63640 since GitHub closed it due to a force-push base change. Regenerated the `package-lock.json` using Node 14.21.3 as requested by @sampan-s-nayak. Bumped axios to `^1.18.0` to fully address GHSA-gcfj-64vw-6mp9. ## Related issues Closes ray-project#63640 ## Additional information Signed-off-by: RinZ27 <222222878+RinZ27@users.noreply.github.com> --- *Note: This is a replacement for PR ray-project#65106 which was automatically closed due to a git history issue.* Signed-off-by: RinZ27 <222222878+RinZ27@users.noreply.github.com>
Description
Re-opening of #63640 since GitHub closed it due to a force-push base change.
Regenerated the
package-lock.jsonusing Node 14.21.3 as requested by @sampan-s-nayak. Bumped axios to^1.18.0to fully address GHSA-gcfj-64vw-6mp9.Related issues
Closes #63640
Additional information
Signed-off-by: RinZ27 222222878+RinZ27@users.noreply.github.com
Note: This is a replacement for PR #65106 which was automatically closed due to a git history issue.