Skip to content

[dashboard] Update axios to ^1.18.0 - #65130

Merged
sampan-s-nayak merged 1 commit into
ray-project:masterfrom
RinZ27:dashboard/axios-upgrade
Aug 3, 2026
Merged

[dashboard] Update axios to ^1.18.0#65130
sampan-s-nayak merged 1 commit into
ray-project:masterfrom
RinZ27:dashboard/axios-upgrade

Conversation

@RinZ27

@RinZ27 RinZ27 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Description

Re-opening of #63640 since GitHub closed it due to a force-push base change.

Regenerated the package-lock.json using Node 14.21.3 as requested by @sampan-s-nayak. Bumped axios to ^1.18.0 to fully address GHSA-gcfj-64vw-6mp9.

Related issues

Closes #63640

Additional information

Signed-off-by: RinZ27 222222878+RinZ27@users.noreply.github.com


Note: This is a replacement for PR #65106 which was automatically closed due to a git history issue.

Signed-off-by: RinZ27 <222222878+RinZ27@users.noreply.github.com>
@RinZ27
RinZ27 requested a review from a team as a code owner July 30, 2026 13:11

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the axios dependency from version 0.21.x to 1.18.1 in the dashboard client. However, the changes in requestHandlers.ts attempt to import create as a named export from axios and call it directly. The reviewer correctly identified that axios does not support create as a named export, which will cause compilation or runtime errors, and recommended reverting to importing the default axios object and using axios.create().

Comment thread python/ray/dashboard/client/src/service/requestHandlers.ts
Comment thread python/ray/dashboard/client/src/service/requestHandlers.ts
@ray-gardener ray-gardener Bot added core Issues that should be addressed in Ray Core security The issue or proposal related to security community-contribution Contributed by the community labels Jul 30, 2026
@rueian rueian self-assigned this Jul 30, 2026
@rueian

rueian commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@RinZ27, could you verify that all the usages of axios in our codebase are not affected by its breaking changes?

@sampan-s-nayak sampan-s-nayak added the go add ONLY when ready to merge, run all tests label Aug 2, 2026
@sampan-s-nayak

Copy link
Copy Markdown
Contributor

I think the requestHandler.ts changes got missed PTAL, refer: #65106 (comment)

@RinZ27
RinZ27 force-pushed the dashboard/axios-upgrade branch from 41a89c8 to 0a8f3f2 Compare August 2, 2026 12:48
@RinZ27

RinZ27 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

@sampan-s-nayak An automated bot previously suggested reverting the named create import because it thought the feature wasn't supported in axios, which got merged into the branch by mistake. Having looked into the git history, I just dropped those bad commits entirely. We are now back to the correct named export fix you suggested to keep the CI happy.

@sampan-s-nayak

Copy link
Copy Markdown
Contributor

Thanks @RinZ27 for working on this. I tried running a sample job locally with these changes and I am able to access different pages of the dashboard. merging this pr.

@sampan-s-nayak
sampan-s-nayak merged commit 5327738 into ray-project:master Aug 3, 2026
7 checks passed
goutamvenkat-anyscale pushed a commit to goutamvenkat-anyscale/ray that referenced this pull request Aug 3, 2026
## Description
Re-opening of ray-project#63640 since GitHub closed it due to a force-push base
change.

Regenerated the `package-lock.json` using Node 14.21.3 as requested by
@sampan-s-nayak. Bumped axios to `^1.18.0` to fully address
GHSA-gcfj-64vw-6mp9.

## Related issues
Closes ray-project#63640

## Additional information
Signed-off-by: RinZ27 <222222878+RinZ27@users.noreply.github.com>

---
*Note: This is a replacement for PR ray-project#65106 which was automatically
closed due to a git history issue.*

Signed-off-by: RinZ27 <222222878+RinZ27@users.noreply.github.com>
@RinZ27
RinZ27 deleted the dashboard/axios-upgrade branch August 4, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Contributed by the community core Issues that should be addressed in Ray Core go add ONLY when ready to merge, run all tests security The issue or proposal related to security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants